-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lambda): add toString to lambda architecture #26145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a unit test for this?
5f4a004
to
46261ac
Compare
60c1b9f
to
e5b29be
Compare
e5b29be
to
00b9c84
Compare
7fcce5a
to
3aa874b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukey-aleios How are you doing with the unit test? If you need any help checkout the Community Slack on cdk.dev channel #contributing
Hey! I've been away for the past two weeks so will be able to get to this early next week 😄 |
Awesome, thank you! |
If the automation closes your PR, please just open a new one once you have had time to address any issues. Pro tip: Open the PR in Draft mode and our automation won't touch it. |
Your test case doesn't quite work out
|
f2a595b
to
0910e55
Compare
Should be fixed now! |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Add toString to Lambda Architecture property When throwing errors during synthesis, you can't see the architecture chosen for a lambda. Adding this toString method solves that Closes #26117 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add toString to Lambda Architecture property When throwing errors during synthesis, you can't see the architecture chosen for a lambda. Adding this toString method solves that Closes aws#26117 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add toString to Lambda Architecture property
When throwing errors during synthesis, you can't see the architecture chosen for a lambda. Adding this toString method solves that
Closes #26117
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license