Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(batch-alpha): cannot import FargateComputeEnvironment with fromFargateComputeEnvironmentArn #25985

Merged
merged 3 commits into from
Jun 23, 2023
Merged

fix(batch-alpha): cannot import FargateComputeEnvironment with fromFargateComputeEnvironmentArn #25985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c1d7f0
fix(batch-alpha): cannot import FargateComputeEnvironment with fromFa…
lpizzinidev Jun 15, 2023
09d82e2
Merge branch 'main' into gh-25979
lpizzinidev Jun 15, 2023
54a48ce
Merge branch 'main' into gh-25979
mergify[bot] Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/@aws-cdk/aws-batch-alpha/lib/managed-compute-environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1068,15 +1068,17 @@ export class FargateComputeEnvironment extends ManagedComputeEnvironmentBase imp
const stack = Stack.of(scope);
const computeEnvironmentName = stack.splitArn(fargateComputeEnvironmentArn, ArnFormat.SLASH_RESOURCE_NAME).resourceName!;

class Import extends ManagedComputeEnvironmentBase implements IFargateComputeEnvironment {
class Import extends Resource implements IFargateComputeEnvironment {
public readonly computeEnvironmentArn = fargateComputeEnvironmentArn;
public readonly computeEnvironmentName = computeEnvironmentName;
public readonly enabled = true;
public readonly maxvCpus = 1;
public readonly connections = { } as any;
public readonly securityGroups = [];
public readonly tags: TagManager = new TagManager(TagType.MAP, 'AWS::Batch::ComputeEnvironment');
}

return new Import(scope, id, {
vpc: undefined as any,
});
return new Import(scope, id);
}

public readonly computeEnvironmentName: string;
Expand Down
8 changes: 8 additions & 0 deletions packages/@aws-cdk/aws-batch-alpha/test/managed-compute-environment.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -935,4 +935,12 @@ describe('FargateComputeEnvironment', () => {
ComputeEnvironmentName: 'maxPropsFargateCE',
});
});

test('can be imported from arn', () => {
// WHEN
const ce = FargateComputeEnvironment.fromFargateComputeEnvironmentArn(stack, 'import', 'arn:aws:batch:us-east-1:123456789012:compute-environment/ce-name');

// THEN
expect(ce.computeEnvironmentArn).toEqual('arn:aws:batch:us-east-1:123456789012:compute-environment/ce-name');
});
});