Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove npm bin from scripts #25913

Merged
merged 3 commits into from
Jun 12, 2023
Merged

chore: Remove npm bin from scripts #25913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb02701
Remove `npm bin` from build.sh
douglasnaphas Jun 9, 2023
74bde33
Remove `npm bin` from `scripts/gen.sh`.
douglasnaphas Jun 9, 2023
415dc20
Merge branch 'main' into rm-npm-bin
mergify[bot] Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ while [[ "${1:-}" != "" ]]; do
shift
done

export PATH=$(npm bin):$PATH
export NODE_OPTIONS="--max-old-space-size=8196 --experimental-worker ${NODE_OPTIONS:-}"

# Temporary log memory for long builds (this may mess with tests that check stderr)
Expand Down
5 changes: 2 additions & 3 deletions scripts/gen.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#!/bin/bash
set -euo pipefail

export PATH=$(npm bin):$PATH
export NODE_OPTIONS="--max-old-space-size=8196 ${NODE_OPTIONS:-}"

echo "============================================================================================="
Expand All @@ -15,8 +14,8 @@ fail() {

echo "============================================================================================="
echo "building required build tools..."
time lerna run --stream build --scope @aws-cdk/cfn2ts --scope @aws-cdk/ubergen --include-dependencies || fail
time npx lerna run --stream build --scope @aws-cdk/cfn2ts --scope @aws-cdk/ubergen --include-dependencies || fail

echo "============================================================================================="
echo "executing gen..."
time lerna run --stream gen || fail
time npx lerna run --stream gen || fail