-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kms): aliasName references alias itself (under feature flag) #25822
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This change breaks my existing code, because of the |
This is because I want to use the name of the alias in a condition statement of my key policy |
FYI doing this to get the raw string again: (key.node.defaultChild as cdk.aws_kms.CfnAlias).aliasName |
Fixes #25761
The existing behavior was that
alias.aliasName
was always a raw string, so properties likekeyId
andkeyArn
depended on a raw string and not a reference to the alias itself. This behavior is preserved.Under a new feature flag,
const KMS_ALIAS_NAME_REF = '@aws-cdk/aws-kms:aliasNameRef'
, we instead use a reference to thealiasName
output itself, which means that properties that depend onaliasName
now depend on thealias
. In turn, thealias
depends on thekey
. This allows the expected behavior where specifying something likealias.keyArn()
depends on the key.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license