Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecr): auto delete images on ECR repository containing manifest list #25391

Closed
wants to merge 4 commits into from

Conversation

hkford
Copy link
Contributor

@hkford hkford commented May 2, 2023

Fixes #24822

As I commented on GitHub issue, auto delete container images in ECR repository fails when it has container manifest list. I fix custom resource Lambda function to delete tagged images first.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 2, 2023

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels May 2, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team May 2, 2023 10:22
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@pahud
Copy link
Contributor

pahud commented May 2, 2023

Hi @hkford feel free to ping me on cdk.dev slack if you need any help to complete this PR.

@pahud pahud changed the title fix(aws-ecr): auto delete images on ECR repository containing manifest list fix(ecr): auto delete images on ECR repository containing manifest list May 2, 2023
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort labels May 2, 2023
@hkford
Copy link
Contributor Author

hkford commented May 3, 2023

Exemption Request - All integration tests remain unchanged so I think we do not need to update snapshots in this PR.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label May 3, 2023
@corymhall corymhall added the @aws-cdk/aws-ecr Related to Amazon Elastic Container Registry label May 8, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 8, 2023
@missourian55
Copy link

@hkford Waiting for this PR to be available. Can you please?

@hkford
Copy link
Contributor Author

hkford commented May 13, 2023

@missourian55
I'm waiting for this PR to be reviewed by maintainer. This PR does not need integration test change.

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@hkford
Copy link
Contributor Author

hkford commented May 25, 2023

Exemption Request - All integration tests remain unchanged so I think we do not need to update snapshots in this PR.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: dfa043c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label May 31, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecr Related to Amazon Elastic Container Registry beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto delete images upon ECR repo removal - CDK v2.70.0 not working
5 participants