feat(appsync): L2 construct for EventBridge DataSource. #25369
Conversation
|
|
github-actions
bot
added
beginning-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
github-actions
bot
added
effort/medium
|
Looks really good to me, hoping to have this soon! |
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
postsa
force-pushed
the
event-bridge-l2-construct
branch
from
a2d08a6
to
7d37b51
Compare
|
Thanks so much @postsa for taking this on and having this close my issue/PR! Would love to give you a shoutout on Twitter/LinkedIn if you want to drop it here. Also next time I'm in Denver, 🍺 on me! |
postsa
force-pushed
the
event-bridge-l2-construct
branch
from
ada7b42
to
3d7637a
Compare
| @@ -232,6 +232,83 @@ httpDs.createResolver('MutationCallStepFunctionResolver', { | |||
| }); | |||
| ``` | |||
|
|
|||
| ### EventBridge | |||
|
|
|||
| GraphQL schema file `schema.graphql`: | |||
There was a problem hiding this comment.
Not being familiar with the event bridge integration, based on the mapping templates/schema, it looks like most of these types are just raw inputs/outputs from event bridge. Can we explain that in the docs a little bit?
| @@ -232,6 +232,83 @@ httpDs.createResolver('MutationCallStepFunctionResolver', { | |||
| }); | |||
| ``` | |||
|
|
|||
| ### EventBridge | |||
There was a problem hiding this comment.
Can we add 1 or 2 sentences saying when using event bridge + appsync is beneficial. A general use case etc?
We are probably missing these for other integrations but still a good thing to add.
postsa
force-pushed
the
event-bridge-l2-construct
branch
from
3d7637a
to
a69871b
Compare
mergify
bot
dismissed
MrArnoldPalmer’s stale review
Pull request has been modified.
|
@MrArnoldPalmer I took a crack at those README updates. Thanks for the suggestions. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Adds an L2 EventBridge data source to AppSync.
Closes #24809.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license