Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lambda-nodejs): pin pnpm version to 7 #24837

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Conversation

HBobertz
Copy link
Contributor

pinning to 7 as default nodejs runtime is node14 which is incompatible with 8


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Mar 28, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team March 28, 2023 22:04
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 28, 2023
@corymhall corymhall added the pr/do-not-merge This PR should not be merged at this time. label Mar 28, 2023
@corymhall
Copy link
Contributor

Adding do-not-merge until this has been run through the test-pipeline

@HBobertz HBobertz removed the pr/do-not-merge This PR should not be merged at this time. label Mar 29, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1fecb17
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2385f6b into main Mar 29, 2023
@mergify mergify bot deleted the bobertzh/fix/pnpm-version branch March 29, 2023 03:32
@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

corymhall pushed a commit that referenced this pull request Mar 29, 2023
pinning to 7 as default nodejs runtime is node14 which is incompatible with 8

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@0xdevalias
Copy link
Contributor

FYI, this PR is partially related to causing the following issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants