Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-nodejs): pnpm no longer supports nodejs14.x #24821

Merged
merged 2 commits into from
Mar 28, 2023
Merged

fix(lambda-nodejs): pnpm no longer supports nodejs14.x #24821

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a63692b
fix(lambda-nodejs): pnpm no longer supports nodejs14.x
corymhall Mar 28, 2023
20feb70
updating integ tests
corymhall Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@aws-cdk/aws-lambda-nodejs/lib/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
# The correct AWS SAM build image based on the runtime of the function will be
# passed as build arg. The default allows to do `docker build .` when testing.
ARG IMAGE=public.ecr.aws/sam/build-nodejs14.x
ARG IMAGE=public.ecr.aws/sam/build-nodejs18.x
FROM $IMAGE

# Install yarn
RUN npm install --global [email protected]

# Install pnpm
RUN npm install --global pnpm
RUN npm install --global pnpm@8.0.0

# Install typescript
RUN npm install --global typescript
Expand Down
4 changes: 3 additions & 1 deletion packages/@aws-cdk/aws-lambda-nodejs/test/docker.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ import * as path from 'path';

const docker = process.env.CDK_DOCKER ?? 'docker';
beforeAll(() => {
spawnSync(docker, ['build', '-t', 'esbuild', path.join(__dirname, '../lib')]);
const process = spawnSync(docker, ['build', '-t', 'esbuild', path.join(__dirname, '../lib')], { stdio: 'inherit' });
expect(process.error).toBeUndefined();
expect(process.status).toBe(0);
});

test('esbuild is available', () => {
Expand Down