fix(WAFv2): add patch to revert struct names #24651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vinayak Kukreja <[email protected]>
aws-cdk-automation
previously requested changes
Mar 16, 2023
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
Signed-off-by: Vinayak Kukreja <[email protected]>
rix0rrr
reviewed
Mar 16, 2023
Comment on lines
6
to
12
| "op": "remove", | ||
| "path": "PropertyTypes/AWS::WAFv2::RuleGroup.AllowAction" | ||
| }, | ||
| { | ||
| "op": "add", | ||
| "path": "PropertyTypes/AWS::WAFv2::RuleGroup.Allow", | ||
| "value": { |
Signed-off-by: Vinayak Kukreja <[email protected]>
vinayak-kukreja
commented
Mar 16, 2023
| } | ||
| ] | ||
| } | ||
| } |
There was a problem hiding this comment.
We do not need to fix types with this patch since those already get replaced in another patch.
Signed-off-by: Vinayak Kukreja <[email protected]>
Signed-off-by: Vinayak Kukreja <[email protected]>
vinayak-kukreja
added
the
pr-linter/exemption-requested
|
Exemption Request |
otaviomacedo
approved these changes
Mar 17, 2023
vinayak-kukreja
changed the title
otaviomacedo
added
pr-linter/exempt-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
mergify bot
pushed a commit
to cdklabs/aws-cdk-notices
that referenced
this pull request
Mar 17, 2023
CLI notice for WAFv2 RuleGroup struct name changes. Being patched here: aws/aws-cdk#24651
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
This PR is reverting the property type names from pattern `FooAction` to `Foo` for `WAFv2` resource. This change was introduced as part of a [CFNSpec merge](affe040#diff-827a2fd012e049c7ccedffa0360c12e7d967a173f36b8150de73ef6adc42ee4cL175-L357) and would be breaking existing customers if they were using previous property names. Duplicating from [PR](#24651) for same issue for V2. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
homakk
pushed a commit
to homakk/aws-cdk
that referenced
this pull request
Mar 28, 2023
This PR is reverting the property type names from pattern `FooAction` to `Foo` for `WAFv2` resource. This change was introduced as part of a [CFNSpec merge](aws@affe040#diff-827a2fd012e049c7ccedffa0360c12e7d967a173f36b8150de73ef6adc42ee4cL175-L357) and would be breaking existing customers if they were using previous property names. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is reverting the property type names from pattern
FooActiontoFooforWAFv2resource. This change was introduced as part of a CFNSpec merge and would be breaking existing customers if they were using previous property names.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license