fix(cdk-assets): asset concurrency leaves a corrupted archive #24026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
bug
rix0rrr
added
pr-linter/exempt-test
#23677) Resolves #23290 A very simple fix for the issue where builds with `--concurrency` specified can lead to corrupt archives. Rather than use the outputFile as the basis for the temp file name we simply use a random UUID. Please note that I was unable to run the integration tests in this instance, which are likely necessary given that this change impacts the behavior of the archiver.
rix0rrr
force-pushed
the
huijbers/re-roll-assets
branch
from
0f7f6af to
3d10bc8
Compare
otaviomacedo
approved these changes
Feb 6, 2023
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thanks for re-roll fixing @rix0rrr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-roll of #23677 which was reverted in #23994 because the
randomUUID()function from the original solution was not available in Node versions below 14.17 (and we advertise compatibility with Node 14.*).We didn't actually need a UUID, just any random string, so replace it with a function that generates a random string in a different way.
Resolves #23290
A very simple fix for the issue where builds with
--concurrencyspecified can lead to corrupt archives. Rather than use the outputFile as the basis for the temp file name we simply use a random string.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license