Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): move integ tests to @aws-cdk-testing/cli-integ #23590

Merged
merged 5 commits into from
Jan 17, 2023

Commits on Jan 6, 2023

  1. chore(cli): move integ tests to separate package

    Clean up the CLI integration tests a bit, by moving
    them to a separate package. This has the following
    benefits:
    
    - More clearly isolates the tests and keeps them separate from the CLI
      package proper.
    - Allows normal specification of dependencies of the integration tests
      themselves, via a proper `package.json` and Yarn lockfile.
    - Makes it more clear what reusable files are part of the CLI, vs
      what reusable files are part of the integration tests.
    - Makes it more clear/easier to download an old copy of the tests.
    
    Also makes the following improvement:
    
    - Publishes the test artifacts to CodeArtifact, so that we don't need to
      do crazy shell hijacking shenanigans in order to fake
      NPM/Maven/NuGet/PyPI repositories from a set of artifacts.
    
    This is not the final form of our testing infrastructure. Right now,
    a fresh CodeArtifact repo is created for every test with all packages
    in it. In an actual pipeline, we would be better off publishing to a
    CodeArtifact repo once and all tests pulling from that.
    
    That will be forthcoming in the future.
    rix0rrr committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    b527cf0 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Configuration menu
    Copy the full SHA
    556ad56 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Configuration menu
    Copy the full SHA
    18a570f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f88fdf1 View commit details
    Browse the repository at this point in the history
  3. Incorporate some comments

    rix0rrr committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    4c5f96d View commit details
    Browse the repository at this point in the history