Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change name of integ test snapshot directories in preparation of multi-language integration tests #22716

Merged
merged 7 commits into from
Nov 1, 2022

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Oct 31, 2022

To support multi language integration tests better (see #22521), we need to rename the snapshot directories. Other languages have different naming conventions, so it's not trivial anymore to generate a "nice" name just from a test file. Instead we now use the full filename. This new pattern is inspired by Jest etc that all use the full filename.

E.g. my-test-name.integ.snapshot -> integ.my-test-name.js.snapshot

This PR changes the code generating the snapshot names and then does the rename in one go via the following commits:

  • chore: change code for generating the integ test snapshot directory names
  • chore: rename test data in integ-runner
  • chore: update .gitignore files with new snapshot patterns
  • chore: rename all integ-test snapshots
  • chore: update integ test snapshot paths in docs
  • chore: update .npmignore files with new snapshot pattern
  • chore: update prlinter to detect new snapshot pattern

Review by commit (start here). The middle commit contains most of the renames, is HUGE and takes a long time to load in the GitHub UI. However it only contains renames (use --diff-filter=r to exclude renames from the diff):

> git show --diff-filter=r fee824d161
(empty result)

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 31, 2022

@github-actions github-actions bot added the p2 label Oct 31, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team October 31, 2022 18:31
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 31, 2022
@mrgrain mrgrain force-pushed the chore/integ-snapshot-names branch 2 times, most recently from 3a5867c to 37cfbaf Compare November 1, 2022 10:15
@mrgrain mrgrain force-pushed the chore/integ-snapshot-names branch 2 times, most recently from dc0b91a to 6e20c1e Compare November 1, 2022 10:43
@mrgrain mrgrain marked this pull request as ready for review November 1, 2022 10:48
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7b8999f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 129c695 into aws:main Nov 1, 2022
@mrgrain mrgrain deleted the chore/integ-snapshot-names branch July 26, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants