-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change name of integ test snapshot directories in preparation of multi-language integration tests #22716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
force-pushed
the
chore/integ-snapshot-names
branch
2 times, most recently
from
November 1, 2022 10:15
3a5867c
to
37cfbaf
Compare
mrgrain
force-pushed
the
chore/integ-snapshot-names
branch
2 times, most recently
from
November 1, 2022 10:43
dc0b91a
to
6e20c1e
Compare
mrgrain
force-pushed
the
chore/integ-snapshot-names
branch
from
November 1, 2022 10:52
6e20c1e
to
28e9d86
Compare
mrgrain
force-pushed
the
chore/integ-snapshot-names
branch
from
November 1, 2022 11:12
28e9d86
to
fee824d
Compare
corymhall
suggested changes
Nov 1, 2022
corymhall
approved these changes
Nov 1, 2022
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support multi language integration tests better (see #22521), we need to rename the snapshot directories. Other languages have different naming conventions, so it's not trivial anymore to generate a "nice" name just from a test file. Instead we now use the full filename. This new pattern is inspired by Jest etc that all use the full filename.
E.g.
my-test-name.integ.snapshot
->integ.my-test-name.js.snapshot
This PR changes the code generating the snapshot names and then does the rename in one go via the following commits:
integ-runner
.gitignore
files with new snapshot patterns.npmignore
files with new snapshot patternReview by commit (start here). The middle commit contains most of the renames, is HUGE and takes a long time to load in the GitHub UI. However it only contains renames (use
--diff-filter=r
to exclude renames from the diff):All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integ
to deploy the infrastructure and generate the snapshot (i.e.yarn integ
without--dry-run
)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license