-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(redshift): support enhanced vpc routing when creating redshift cluster #22499
Merged
mergify
merged 4 commits into
aws:main
from
sean-beath:feat(redshift-alpha)/add-enhanced-vpc-routing-option
Oct 18, 2022
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
590761c
added enhanced vpc routing to redshift cluster L2
sean-beath ad53511
updated README to have info about enhanced VPC routing
sean-beath 8ecae68
Merge branch 'main' into feat(redshift-alpha)/add-enhanced-vpc-routin…
sean-beath 37a92bd
Merge branch 'main' into feat(redshift-alpha)/add-enhanced-vpc-routin…
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
...edvpcrouting.integ.snapshot/EnhancedVpcRoutingDefaultTestDeployAssert10B513A1.assets.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
{ | ||
"version": "21.0.0", | ||
"files": { | ||
"21fbb51d7b23f6a6c262b46a9caee79d744a3ac019fd45422d988b96d44b2a22": { | ||
"source": { | ||
"path": "EnhancedVpcRoutingDefaultTestDeployAssert10B513A1.template.json", | ||
"packaging": "file" | ||
}, | ||
"destinations": { | ||
"current_account-current_region": { | ||
"bucketName": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}", | ||
"objectKey": "21fbb51d7b23f6a6c262b46a9caee79d744a3ac019fd45422d988b96d44b2a22.json", | ||
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-file-publishing-role-${AWS::AccountId}-${AWS::Region}" | ||
} | ||
} | ||
} | ||
}, | ||
"dockerImages": {} | ||
} |
36 changes: 36 additions & 0 deletions
36
...vpcrouting.integ.snapshot/EnhancedVpcRoutingDefaultTestDeployAssert10B513A1.template.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
{ | ||
"Parameters": { | ||
"BootstrapVersion": { | ||
"Type": "AWS::SSM::Parameter::Value<String>", | ||
"Default": "/cdk-bootstrap/hnb659fds/version", | ||
"Description": "Version of the CDK Bootstrap resources in this environment, automatically retrieved from SSM Parameter Store. [cdk:skip]" | ||
} | ||
}, | ||
"Rules": { | ||
"CheckBootstrapVersion": { | ||
"Assertions": [ | ||
{ | ||
"Assert": { | ||
"Fn::Not": [ | ||
{ | ||
"Fn::Contains": [ | ||
[ | ||
"1", | ||
"2", | ||
"3", | ||
"4", | ||
"5" | ||
], | ||
{ | ||
"Ref": "BootstrapVersion" | ||
} | ||
] | ||
} | ||
] | ||
}, | ||
"AssertDescription": "CDK bootstrap stack version 6 required. Please run 'cdk bootstrap' with a recent version of the CDK CLI." | ||
} | ||
] | ||
} | ||
} | ||
} |
1 change: 1 addition & 0 deletions
1
packages/@aws-cdk/aws-redshift/test/cluster-enhancedvpcrouting.integ.snapshot/cdk.out
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"version":"21.0.0"} |
12 changes: 12 additions & 0 deletions
12
packages/@aws-cdk/aws-redshift/test/cluster-enhancedvpcrouting.integ.snapshot/integ.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"version": "21.0.0", | ||
"testCases": { | ||
"EnhancedVpcRouting/DefaultTest": { | ||
"stacks": [ | ||
"redshift-enhancedvpcrouting-integ" | ||
], | ||
"assertionStack": "EnhancedVpcRouting/DefaultTest/DeployAssert", | ||
"assertionStackName": "EnhancedVpcRoutingDefaultTestDeployAssert10B513A1" | ||
} | ||
} | ||
} |
273 changes: 273 additions & 0 deletions
273
packages/@aws-cdk/aws-redshift/test/cluster-enhancedvpcrouting.integ.snapshot/manifest.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,273 @@ | ||
{ | ||
"version": "21.0.0", | ||
"artifacts": { | ||
"Tree": { | ||
"type": "cdk:tree", | ||
"properties": { | ||
"file": "tree.json" | ||
} | ||
}, | ||
"redshift-enhancedvpcrouting-integ.assets": { | ||
"type": "cdk:asset-manifest", | ||
"properties": { | ||
"file": "redshift-enhancedvpcrouting-integ.assets.json", | ||
"requiresBootstrapStackVersion": 6, | ||
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version" | ||
} | ||
}, | ||
"redshift-enhancedvpcrouting-integ": { | ||
"type": "aws:cloudformation:stack", | ||
"environment": "aws://unknown-account/unknown-region", | ||
"properties": { | ||
"templateFile": "redshift-enhancedvpcrouting-integ.template.json", | ||
"validateOnSynth": false, | ||
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-deploy-role-${AWS::AccountId}-${AWS::Region}", | ||
"cloudFormationExecutionRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-cfn-exec-role-${AWS::AccountId}-${AWS::Region}", | ||
"stackTemplateAssetObjectUrl": "s3://cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}/88e2010a08d484eca3203f7e1bcffce43eaa10faedbd092b56c3d70967765b7a.json", | ||
"requiresBootstrapStackVersion": 6, | ||
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version", | ||
"additionalDependencies": [ | ||
"redshift-enhancedvpcrouting-integ.assets" | ||
], | ||
"lookupRole": { | ||
"arn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-lookup-role-${AWS::AccountId}-${AWS::Region}", | ||
"requiresBootstrapStackVersion": 8, | ||
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version" | ||
} | ||
}, | ||
"dependencies": [ | ||
"redshift-enhancedvpcrouting-integ.assets" | ||
], | ||
"metadata": { | ||
"/redshift-enhancedvpcrouting-integ/VPC/Resource": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCB9E5F0B4" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/PublicSubnet1/Subnet": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCPublicSubnet1SubnetB4246D30" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/PublicSubnet1/RouteTable": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCPublicSubnet1RouteTableFEE4B781" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/PublicSubnet1/RouteTableAssociation": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCPublicSubnet1RouteTableAssociation0B0896DC" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/PublicSubnet1/DefaultRoute": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCPublicSubnet1DefaultRoute91CEF279" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/PublicSubnet1/EIP": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCPublicSubnet1EIP6AD938E8" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/PublicSubnet1/NATGateway": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCPublicSubnet1NATGatewayE0556630" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/PublicSubnet2/Subnet": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCPublicSubnet2Subnet74179F39" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/PublicSubnet2/RouteTable": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCPublicSubnet2RouteTable6F1A15F1" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/PublicSubnet2/RouteTableAssociation": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCPublicSubnet2RouteTableAssociation5A808732" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/PublicSubnet2/DefaultRoute": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCPublicSubnet2DefaultRouteB7481BBA" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/PublicSubnet2/EIP": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCPublicSubnet2EIP4947BC00" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/PublicSubnet2/NATGateway": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCPublicSubnet2NATGateway3C070193" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/PrivateSubnet1/Subnet": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCPrivateSubnet1Subnet8BCA10E0" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/PrivateSubnet1/RouteTable": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCPrivateSubnet1RouteTableBE8A6027" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/PrivateSubnet1/RouteTableAssociation": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCPrivateSubnet1RouteTableAssociation347902D1" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/PrivateSubnet1/DefaultRoute": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCPrivateSubnet1DefaultRouteAE1D6490" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/PrivateSubnet2/Subnet": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCPrivateSubnet2SubnetCFCDAA7A" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/PrivateSubnet2/RouteTable": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCPrivateSubnet2RouteTable0A19E10E" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/PrivateSubnet2/RouteTableAssociation": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCPrivateSubnet2RouteTableAssociation0C73D413" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/PrivateSubnet2/DefaultRoute": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCPrivateSubnet2DefaultRouteF4F5CFD2" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/IGW": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCIGWB7E252D3" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/VPC/VPCGW": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "VPCVPCGW99B986DC" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/Cluster/Subnets/Default": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "ClusterSubnetsDCFA5CB7" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/Cluster/SecurityGroup/Resource": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "ClusterSecurityGroup0921994B" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/Cluster/Secret/Resource": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "ClusterSecret6368BD0F" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/Cluster/Secret/Attachment/Resource": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "ClusterSecretAttachment769E6258" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/Cluster/Resource": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "ClusterEB0386A7" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/BootstrapVersion": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "BootstrapVersion" | ||
} | ||
], | ||
"/redshift-enhancedvpcrouting-integ/CheckBootstrapVersion": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "CheckBootstrapVersion" | ||
} | ||
] | ||
}, | ||
"displayName": "redshift-enhancedvpcrouting-integ" | ||
}, | ||
"EnhancedVpcRoutingDefaultTestDeployAssert10B513A1.assets": { | ||
"type": "cdk:asset-manifest", | ||
"properties": { | ||
"file": "EnhancedVpcRoutingDefaultTestDeployAssert10B513A1.assets.json", | ||
"requiresBootstrapStackVersion": 6, | ||
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version" | ||
} | ||
}, | ||
"EnhancedVpcRoutingDefaultTestDeployAssert10B513A1": { | ||
"type": "aws:cloudformation:stack", | ||
"environment": "aws://unknown-account/unknown-region", | ||
"properties": { | ||
"templateFile": "EnhancedVpcRoutingDefaultTestDeployAssert10B513A1.template.json", | ||
"validateOnSynth": false, | ||
"assumeRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-deploy-role-${AWS::AccountId}-${AWS::Region}", | ||
"cloudFormationExecutionRoleArn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-cfn-exec-role-${AWS::AccountId}-${AWS::Region}", | ||
"stackTemplateAssetObjectUrl": "s3://cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}/21fbb51d7b23f6a6c262b46a9caee79d744a3ac019fd45422d988b96d44b2a22.json", | ||
"requiresBootstrapStackVersion": 6, | ||
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version", | ||
"additionalDependencies": [ | ||
"EnhancedVpcRoutingDefaultTestDeployAssert10B513A1.assets" | ||
], | ||
"lookupRole": { | ||
"arn": "arn:${AWS::Partition}:iam::${AWS::AccountId}:role/cdk-hnb659fds-lookup-role-${AWS::AccountId}-${AWS::Region}", | ||
"requiresBootstrapStackVersion": 8, | ||
"bootstrapStackVersionSsmParameter": "/cdk-bootstrap/hnb659fds/version" | ||
} | ||
}, | ||
"dependencies": [ | ||
"EnhancedVpcRoutingDefaultTestDeployAssert10B513A1.assets" | ||
], | ||
"metadata": { | ||
"/EnhancedVpcRouting/DefaultTest/DeployAssert/BootstrapVersion": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "BootstrapVersion" | ||
} | ||
], | ||
"/EnhancedVpcRouting/DefaultTest/DeployAssert/CheckBootstrapVersion": [ | ||
{ | ||
"type": "aws:cdk:logicalId", | ||
"data": "CheckBootstrapVersion" | ||
} | ||
] | ||
}, | ||
"displayName": "EnhancedVpcRouting/DefaultTest/DeployAssert" | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great documentation. Thanks!