-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dynamodb): Support iampolicy minimize credential #21673
fix(dynamodb): Support iampolicy minimize credential #21673
Conversation
…ub.com/watany-dev/aws-cdk into dynamodb-iampolicy-minimize-credential
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned that this has the potential to break user's functionality. How do we know that these are the only two permissions needed?
I'll explain some of the overlap with what I wrote in this link The IAMRole (onEvent) to which privileges are added in this process is granted to this Lambda. When checking the AWS SDK for this code, I confirmed that only two DynamoDB actions are available. |
The problem is that often under the hood, the visible APIs call other APIs that this change may now remove permissions for. This is especially true for CloudFormation calls. They are often doing more under the hood than is visible. This comment block gives me even more pause. |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Pull Request Linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
PRs must pass status checks before we can provide a meaningful review.
fixes #20545
As noted in the link below, the following IAM Policy permissions appear sufficient for this support.
#20545 (comment)
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integ
to deploy the infrastructure and generate the snapshot (i.e.yarn integ
without--dry-run
)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license