Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamodb): grant permission to specific indexes when using fromTableAttributes to create a table construct #21451

Closed
wants to merge 3 commits into from

Conversation

YichenQian09
Copy link
Contributor

@YichenQian09 YichenQian09 commented Aug 3, 2022


Motivation:

When creating a table construct from fromTableAttributes, even the user specify the global indexes, all the indexes will be granted permission. Considering the security,it is better to grant resources the least permissive permissions by default.

Use case:

Use the code:

Table.fromTableAttributes(this, "MyTable", {
  tableName: "MyTable",
  globalIndexes: ["foo", "bar"],
}).grantReadData(lambdaFn);

Only the globalIndexes "foo" and "bar" should be granted permission. But now all the global indexes are granted permission.

a basic idea of solution:

  1. change the varible hasIndex in function fromTableAttributes to a string array which contains specific indexes
  2. use the specific indexes to format Arn name of resources in function combinedGrant

maybe close #11445

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Aug 3, 2022

@github-actions github-actions bot added the p2 label Aug 3, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team August 3, 2022 17:42
@TheRealAmazonKendra TheRealAmazonKendra changed the title feat(dynamodb): Grant permission to specific indexes when using fromTableAttributes to create a table construct feat(dynamodb): grant permission to specific indexes when using fromTableAttributes to create a table construct Aug 3, 2022
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were some things missed in this PR? Looks like only two comments were added and no other changes.

@mergify mergify bot dismissed TheRealAmazonKendra’s stale review August 12, 2022 21:00

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 16feffd
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2
Projects
None yet
3 participants