Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove note of go being in dev preview #21130

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Conversation

MrArnoldPalmer
Copy link
Contributor

Removes note in go app init template readmes saying go is in dev preview
since it is not generally available. Also adds note about cdk.json which may
be useful for new users and is present in other language templates.

references: awsdocs/aws-cdk-guide#416


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Removes note in go app init template readmes saying go is in dev preview
since it is not generally available.

references: awsdocs/aws-cdk-guide#416
@MrArnoldPalmer MrArnoldPalmer requested a review from a team July 13, 2022 22:46
@gitpod-io
Copy link

gitpod-io bot commented Jul 13, 2022

@github-actions github-actions bot added the p2 label Jul 13, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team July 13, 2022 22:46
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 13, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: eb295f0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f15cb27 into main Jul 13, 2022
@mergify mergify bot deleted the chore/go-dev-preview-init branch July 13, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants