-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): addToRolePolicy()
for custom resource provider
#20449
Conversation
Since we only get a singleton we need a `addToRolePolicy()` method to add statements when the singleton is used for multiple custom resources.
Can be used to simplify/rewrite the following: aws-cdk/packages/@aws-cdk/aws-cloudfront/lib/experimental/edge-function.ts Lines 181 to 190 in 87dd2a6
aws-cdk/packages/@aws-cdk/aws-route53/lib/record-set.ts Lines 686 to 697 in 87dd2a6
For this PR? |
Needs |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Since we only get a singleton we need a
addToRolePolicy()
method toadd statements when the singleton is used for multiple custom resources.
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integ
to deploy the infrastructure and generate the snapshot (i.e.yarn integ
without--dry-run
)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license