Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cfnspec): cloudformation spec v69.0.0 #20240

Merged
merged 9 commits into from
May 12, 2022
Merged

feat(cfnspec): cloudformation spec v69.0.0 #20240

merged 9 commits into from
May 12, 2022

Conversation

aws-cdk-automation
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation commented May 6, 2022 •
edited
Loading

No description provided.

@aws-cdk-automation aws-cdk-automation added auto-approve pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels May 6, 2022
@gitpod-io
Copy link

gitpod-io bot commented May 6, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team May 6, 2022 09:06
@github-actions github-actions bot added the p2 label May 6, 2022
github-actions[bot]
github-actions bot previously approved these changes May 6, 2022
View reviewed changes
@mergify mergify bot dismissed github-actions[bot]’s stale review May 6, 2022 16:18

Pull request has been modified.

github-actions[bot]
github-actions bot previously approved these changes May 6, 2022
View reviewed changes
@mergify mergify bot dismissed github-actions[bot]’s stale review May 6, 2022 17:23

Pull request has been modified.

github-actions[bot]
github-actions bot previously approved these changes May 6, 2022
View reviewed changes
@kaizencc kaizencc added the pr/do-not-merge This PR should not be merged at this time. label May 6, 2022
@mergify mergify bot dismissed github-actions[bot]’s stale review May 6, 2022 18:40

Pull request has been modified.

@kaizencc
Copy link
Contributor

kaizencc commented May 6, 2022

Well, I'm having some problems with this one! Latest spec includes some new properties, InclusivePrimitiveItemTypes and InclusiveItemTypes and our current schema is not built to support them. Leaving this incomplete for now until I figure out what to do.

github-actions[bot]
github-actions bot previously approved these changes May 11, 2022
View reviewed changes
@mergify mergify bot dismissed github-actions[bot]’s stale review May 11, 2022 16:40

Pull request has been modified.

github-actions[bot]
github-actions bot previously approved these changes May 11, 2022
View reviewed changes
@mergify mergify bot dismissed github-actions[bot]’s stale review May 11, 2022 22:21

Pull request has been modified.

github-actions[bot]
github-actions bot previously approved these changes May 11, 2022
View reviewed changes
@mergify mergify bot dismissed github-actions[bot]’s stale review May 11, 2022 22:29

Pull request has been modified.

@kaizencc kaizencc removed the pr/do-not-merge This PR should not be merged at this time. label May 12, 2022
@mergify
Copy link
Contributor

mergify bot commented May 12, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 263bb5f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e82b63f into master May 12, 2022
@mergify mergify bot deleted the bump-cfnspec/v69.0.0 branch May 12, 2022 15:54
@mergify
Copy link
Contributor

mergify bot commented May 12, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@corymhall corymhall mentioned this pull request May 17, 2022
Closed
wphilipw pushed a commit to wphilipw/aws-cdk that referenced this pull request May 23, 2022
@aws-cdk-automation @wphilipw
feat(cfnspec): cloudformation spec v69.0.0 (aws#20240)
332f0af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees
No one assigned
Labels
auto-approve p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aws-cdk-automation @kaizencc @rix0rrr