Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): --force flag and glob-style key matches for context --reset #19890

Merged
merged 3 commits into from
Jul 14, 2022

Conversation

gillisandrew
Copy link
Contributor

@gillisandrew gillisandrew commented Apr 13, 2022

New pull request for glob style key matches in context --reset (#19840)

Adds the --force flag to ignore missing key errors.

This is in response to #19888


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Apr 13, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team April 13, 2022 00:27
@github-actions github-actions bot added the p2 label Apr 13, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2022

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@gillisandrew gillisandrew changed the title add missing --force flag from the integration test feat(cli): Context key matches and implement --force flag Apr 13, 2022
@gillisandrew gillisandrew changed the title feat(cli): Context key matches and implement --force flag feat(cli): Implement --force flag for context --reset Apr 13, 2022
@gillisandrew gillisandrew force-pushed the context-reset-matches branch from 1ece482 to df5e823 Compare April 13, 2022 01:04
@gillisandrew gillisandrew changed the title feat(cli): Implement --force flag for context --reset feat(cli): --force flag and glob-style key matches for context --reset Apr 13, 2022
@TheRealAmazonKendra TheRealAmazonKendra changed the base branch from v1-main to main July 13, 2022 00:06
@TheRealAmazonKendra TheRealAmazonKendra added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jul 13, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7cc696c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 39a7c1f into aws:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants