Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove unnecessary $ that begins each line of code for copy/paste #19768

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

stevebanik
Copy link
Contributor

@stevebanik stevebanik commented Apr 5, 2022

Removing $ allows users to easily copy/paste the code blocks, otherwise they have to remove $ on each line of the paste.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use cdk-integ to deploy the infrastructure and generate the snapshot (i.e. cdk-integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Removing $ allows users to easily copy/paste the code blocks, otherwise they have to remove $ on each line of the paste.
@gitpod-io
Copy link

gitpod-io bot commented Apr 5, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team April 5, 2022 18:29
@github-actions github-actions bot added the p2 label Apr 5, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2022

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@stevebanik stevebanik changed the title Removing $ docs: remove unnecessary $ that begins each line of code for copy/paste Apr 5, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 294053a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f351e06 into aws:master Apr 5, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@stevebanik stevebanik deleted the patch-1 branch April 5, 2022 20:11
StevePotter pushed a commit to StevePotter/aws-cdk that referenced this pull request Apr 27, 2022
…te (aws#19768)

Removing $ allows users to easily copy/paste the code blocks, otherwise they have to remove $ on each line of the paste.


----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants