Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docdb): DB Instance ARN uses 'docdb' as the service component instead of 'rds' #19555

Merged
merged 2 commits into from
Mar 29, 2022

Conversation

peterwoodworth
Copy link
Contributor

@peterwoodworth peterwoodworth commented Mar 25, 2022

Fixes #19554


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use cdk-integ to deploy the infrastructure and generate the snapshot (i.e. cdk-integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 25, 2022

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 25, 2022
@github-actions github-actions bot added the @aws-cdk/aws-docdb Related to Amazon DocumentDB label Mar 25, 2022
@github-actions github-actions bot added the p2 label Mar 25, 2022
@peterwoodworth peterwoodworth added p1 effort/small Small work item – less than a day of effort and removed p2 labels Mar 25, 2022
@github-actions github-actions bot added p2 bug This issue is a bug. p1 and removed p1 p2 labels Mar 25, 2022
@skinny85 skinny85 changed the title fix(docdb): databaseInstance arn built with incorrect service fix(docdb): DB Instance ARN uses 'docdb' as the service component instead of 'rds' Mar 29, 2022
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 9b2b0d7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6a63924 into master Mar 29, 2022
@mergify mergify bot deleted the peterwoodworth/arnFix branch March 29, 2022 01:30
@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

StevePotter pushed a commit to StevePotter/aws-cdk that referenced this pull request Apr 27, 2022
…tead of 'rds' (aws#19555)

Fixes aws#19554

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-docdb Related to Amazon DocumentDB bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(docdb): incorrect arn generation DatabaseInstance
3 participants