build: Allow using jest as a test framework #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a package's `package.json` file contains a `jest` entry (used for configuring the behavior of `jest`), assert the package uses `jest` instead of `nodeunit` as it's test harness (and fail if there are any `nodeunit` tests - based on file name). This is going to make it easier to migrate away from `nodeunit`.
sam-goodwin
reviewed
Mar 6, 2019
|
|
||
| if (useJest) { | ||
| if (testFiles.length > 0) { | ||
| throw new Error(`Jest is enabled, but ${testFiles.length} nodeunit tests were found!`); |
There was a problem hiding this comment.
So a package must be entirely jest or nodeunit to work?
There was a problem hiding this comment.
Yes. We could allow both but would have to merge coverage data & the likes, which is possible but ugly as heck. I don't need this right now so not getting into this... We can do that later if there is a real value to it.
sam-goodwin
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a package's
package.jsonfile contains ajestentry (used forconfiguring the behavior of
jest), assert the package usesjestinstead of
nodeunitas it's test harness (and fail if there are anynodeunittests - based on file name).This is going to make it easier to migrate away from
nodeunit.