Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elbv2): use addAction() on an imported application listener #19293

Merged
merged 2 commits into from
Mar 31, 2022
Merged

feat(elbv2): use addAction() on an imported application listener #19293

merged 2 commits into from
Mar 31, 2022

Conversation

corymhall
Copy link
Contributor

@corymhall corymhall commented Mar 8, 2022

This PR adds the ability to call addAction() on an imported
IApplicationListener.

Fixes #10902


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This PR adds the ability to call `addAction()` on an imported
`IApplicationListener`.

re #10902
@gitpod-io
Copy link

gitpod-io bot commented Mar 8, 2022

@github-actions github-actions bot added the @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 label Mar 8, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 8, 2022
@corymhall corymhall requested a review from a team March 8, 2022 20:40
@rix0rrr rix0rrr added feature-request A feature should be added or improved. p1 and removed contribution/core This is a PR that came from AWS. @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 labels Mar 8, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 8, 2022
@corymhall corymhall added the pr-linter/exempt-readme The PR linter will not require README changes label Mar 22, 2022
@corymhall
Copy link
Contributor Author

I don't this this update needs a README update.

@rix0rrr rix0rrr added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Mar 31, 2022
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Mar 31, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 18a6b0c into aws:master Mar 31, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 2ad32c7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

StevePotter pushed a commit to StevePotter/aws-cdk that referenced this pull request Apr 27, 2022
…ws#19293)

This PR adds the ability to call `addAction()` on an imported
`IApplicationListener`.

Fixes aws#10902


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[elasticloadbalancingv2] add addAction() to IApplicationListener and imported application listeners.
3 participants