Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cxapi): plugin context provider limited by cx schema #18709

Merged
merged 4 commits into from
Feb 4, 2022

Commits on Jan 28, 2022

  1. chore(cxapi): plugin context provider limited by cx schema

    During internal trialing of context provider plugins, we discovered that
    the JSON schema validation of the Cloud Assembly is throwing soot into
    our food: any properties we add aren't exactly those of another context
    provider, and therefore not allowed.
    
    Add a new branch of the context provider schema, a `PluginContextQuery`,
    which allows any set of properties. The actual plugin name is now merely
    a property passed to the "plugin" context provider.
    
    When the handler is registered or the query is handled, we combine the
    key in the lookup table with the actual provider name as such:
    `plugin:${pluginName}`. This is an implementation detail of the CLI, and
    not part of the contract (can be changed easily whenver necessary).
    rix0rrr committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    7e909fb View commit details
    Browse the repository at this point in the history
  2. yarn update-schema

    rix0rrr committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    a479405 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2022

  1. Configuration menu
    Copy the full SHA
    f5c2415 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2022

  1. Configuration menu
    Copy the full SHA
    9de93f0 View commit details
    Browse the repository at this point in the history