feat(iotevents): add grant method to Input class #18617
Conversation
|
|
There was a problem hiding this comment.
Looks great @yamatatsu! As always 🙂. Minor notes related mostly to docs.
mergify
bot
dismissed
skinny85’s stale review
Pull request has been modified.
There was a problem hiding this comment.
Apologies I missed this @yamatatsu! A couple of minor notes/questions.
| * @attribute | ||
| */ | ||
| readonly inputName: string; | ||
|
|
||
| /** | ||
| * The ARN of the input |
There was a problem hiding this comment.
| * The ARN of the input | |
| * The ARN of the input. |
There was a problem hiding this comment.
I've fix all same case in aws-iotevents 👍🏻
| grantee, | ||
| actions, | ||
| resourceArns: [this.inputArn], | ||
| scope: this, |
There was a problem hiding this comment.
Hmm. Why are we passing this argument here? I don't think it's required?
There was a problem hiding this comment.
Oh. I copied from DynamoDB Table grant. I removed and confirm the test is passed.
| * | ||
| * @param grantee the principal | ||
| */ | ||
| grantPutMessage(grantee: iam.IGrantable): iam.Grant |
There was a problem hiding this comment.
What do you actually think of renaming this to grantWrite()? Maybe that's a better name, and will allow us to expand the set of granted permissions here as needed in the future?
There was a problem hiding this comment.
Sound's good!
will allow us to expand the set of granted permissions here as needed in the future?
That's reasonable!
There was a problem hiding this comment.
So... why is this grantPushMessage() still? 😛
Co-authored-by: Adam Ruka <[email protected]>
Co-authored-by: Adam Ruka <[email protected]>
mergify
bot
dismissed
skinny85’s stale review
Pull request has been modified.
Co-authored-by: Adam Ruka <[email protected]>
There was a problem hiding this comment.
I think there are some merge conflicts with master that you need to solve @yamatatsu!
| * | ||
| * @param grantee the principal | ||
| */ | ||
| grantPutMessage(grantee: iam.IGrantable): iam.Grant |
There was a problem hiding this comment.
So... why is this grantPushMessage() still? 😛
mergify
bot
dismissed
skinny85’s stale review
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
* origin/master: (27 commits) chore(eks): deprecate older versions of EKS (aws#18842) fix(tooling): update vscode devcontainer image (aws#18455) chore: npm-check-updates && yarn upgrade (aws#18832) chore(docs): Fix broken md links (aws#18384) chore(lambda-layer-awscli): install awscli with pip and requirements.txt (aws#18800) fix(aws-appsync): Strip unsupported characters from Lambda DataSource (aws#18765) feat(cfnspec): cloudformation spec v55.0.0 (aws#18827) docs(cfnspec): update CloudFormation documentation (aws#18826) chore(cxapi): plugin context provider limited by cx schema (aws#18709) feat(iotevents): add grant method to Input class (aws#18617) chore(cx-api): break circular dependencies (aws#18767) docs(core): clarify that `addOverride` does not change property casing (aws#18687) feat(s3-deployment): deploy data with deploy-time values (aws#18659) docs(cfnspec): update CloudFormation documentation (aws#18808) feat(cli): `cdk diff` works for Nested Stacks (aws#18207) docs(cfnspec): update CloudFormation documentation (aws#18783) chore(lambda-layer-awscli): add update mechanism for AWS CLI (aws#18780) chore(release): 1.143.0 feat(fsx): add support for FSx Lustre Persistent_2 deployment type (aws#18626) feat(amplify): support performance mode in Branch (aws#18598) ...
This PR add `grant` method to `Input` class. Next of this PR, I aim to create PR that add IoT Event Action to IoT Core Rule. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR add
grantmethod toInputclass.Next of this PR, I aim to create PR that add IoT Event Action to IoT Core Rule.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license