Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(lambda-python): Update default value for BundlingOptions.outputPathSuffix #18231

Merged

Conversation

madeline-k
Copy link
Contributor

The current default value of ''' is incorrect, and also causing the generated python for this module to have incorrect syntax, since ''' is the mult-line comment delimiter in python.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 31, 2021

@madeline-k madeline-k requested a review from a team December 31, 2021 00:52
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 31, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 05cdb24
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e2cb83b into aws:master Dec 31, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 31, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…athSuffix (aws#18231)

The current default value of `'''` is incorrect, and also causing the generated python for this module to have incorrect syntax, since `'''` is the mult-line comment delimiter in python. 


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda-python contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants