Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ecs): correct comment documentation for NetworkMode #17841

Merged
merged 4 commits into from
Feb 1, 2022
Merged

docs(ecs): correct comment documentation for NetworkMode #17841

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb20a32
chore(aws-ecs): correct comment documentation
jeffb4 Dec 4, 2021
cc839bd
Merge branch 'master' into minor-network-mode-casefix
jeffb4 Dec 8, 2021
d88dc89
Merge branch 'master' into minor-network-mode-casefix
jeffb4 Jan 28, 2022
a7f2db4
Merge branch 'master' into minor-network-mode-casefix
mergify[bot] Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@aws-cdk/aws-ecs/lib/ec2/ec2-task-definition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ export interface Ec2TaskDefinitionProps extends CommonTaskDefinitionProps {
/**
* The Docker networking mode to use for the containers in the task.
*
* The valid values are none, bridge, awsvpc, and host.
* The valid values are NONE, BRIDGE, AWS_VPC, and HOST.
*
* @default - NetworkMode.Bridge for EC2 tasks, AwsVpc for Fargate tasks.
* @default - NetworkMode.BRIDGE for EC2 tasks, AWS_VPC for Fargate tasks.
*/
readonly networkMode?: NetworkMode;

Expand Down