Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: re-enable example 'strict' mode where possible #17421

Merged
merged 17 commits into from
Nov 9, 2021

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Nov 9, 2021

This will prevent regression in compilation status for the top 25 construct libraries, that we've gone through the effort of making compile.

This also gets rid of the @example values in most of the construct libraries here.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr rix0rrr requested a review from kaizencc November 9, 2021 14:22
@rix0rrr rix0rrr self-assigned this Nov 9, 2021
@gitpod-io
Copy link

gitpod-io bot commented Nov 9, 2021

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Nov 9, 2021

TODO:

  • aws-applicationautoscaling
  • aws-s3
  • aws-stepfunctions
  • aws-apigatewayv2
  • aws-elasticloadbalancingv2
  • aws-stepfunctions-tasks
  • aws-codepipeline-actions
  • pipelines

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 9, 2021
@rix0rrr rix0rrr changed the title docs: re-enable 'strict' mode for examples in many packages docs: re-enable example 'strict' mode where possible Nov 9, 2021
@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Nov 9, 2021
@rix0rrr rix0rrr removed the pr/do-not-merge This PR should not be merged at this time. label Nov 9, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 596db3b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit acd64f4 into master Nov 9, 2021
@mergify mergify bot deleted the huijbers/re-enable-rosetta-strict branch November 9, 2021 19:11
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
This will prevent regression in compilation status for the top 25 construct libraries, that we've gone through the effort of making compile.

This also gets rid of the `@example` values in most of the construct libraries here.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants