-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sagemaker): add model hosting L2 constructs #17399
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Any reason why this got never merged? |
As the submitter of the earlier PR #6107 on which this newer PR was based, I too am interested in the answer to Philipp's question above. Specifically, I'd like to know which of the following paths forward the CDK folks would like to take with the SageMaker L2 constructs:
|
This PR has been in BUILD FAILING for 21 days, and looks abandoned. It will be closed in 10 days if no further commits are pushed to it. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Amazon.CDK.Lib](https://togithub.com/aws/aws-cdk) | nuget | minor | `2.73.0` -> `2.74.0` | --- ### Release Notes <details> <summary>aws/aws-cdk</summary> ### [`v2.74.0`](https://togithub.com/aws/aws-cdk/releases/tag/v2.74.0) ##### ⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES - **batch:** `ComputeEnvironment` has been removed and replaced by `ManagedEc2EcsComputeEnvironment`, `ManagedEc2EksComputeEnvironment`, and `UnmanagedComputeEnvironment`. `JobDefinition` has been removed and replaced by `EcsJobDefinition`, `EksJobDefinition`, and `MultiNodeJobDefinition` ##### Features - **batch:** new L2 Constructs ([#​24775](https://togithub.com/aws/aws-cdk/issues/24775)) ([92e6c67](https://togithub.com/aws/aws-cdk/commit/92e6c6706aae72d406cb5bf6a3f5c4d4885a5cb2)) - **ec2:** added ulimits property to ContainerDefinitionOptions ([#​24963](https://togithub.com/aws/aws-cdk/issues/24963)) ([e37d16a](https://togithub.com/aws/aws-cdk/commit/e37d16ada1572518b4859c9dbf68e9f08eb3f4eb)), closes [#​24918](https://togithub.com/aws/aws-cdk/issues/24918) - **pipelines:** allow artifactBucket to be overridden ([#​24945](https://togithub.com/aws/aws-cdk/issues/24945)) ([292c846](https://togithub.com/aws/aws-cdk/commit/292c846531cc3ecb033569953ebad1826d06c341)) - **sagemaker:** support dlc images in sagemaker model ([#​25018](https://togithub.com/aws/aws-cdk/issues/25018)) ([91553e5](https://togithub.com/aws/aws-cdk/commit/91553e5622fd702e5137f253d266e93b5f0b1a5e)), closes [/github.com/aws/aws-cdk/pull/17399/files#diff-356f35099770f68f4ceee2e63d34aad8729b0a9be6c933a0c05e999be7374685R98-R145](https://togithub.com/aws//github.com/aws/aws-cdk/pull/17399/files/issues/diff-356f35099770f68f4ceee2e63d34aad8729b0a9be6c933a0c05e999be7374685R98-R145) - **ses:** event destinations for configuration sets ([#​24745](https://togithub.com/aws/aws-cdk/issues/24745)) ([3be43eb](https://togithub.com/aws/aws-cdk/commit/3be43eb1f467a0defcca6a298fd7c5c41ab80b6e)) - **step-functions-tasks:** Support PropagatedTagSource property for EcsRunTask ([#​24949](https://togithub.com/aws/aws-cdk/issues/24949)) ([a98a981](https://togithub.com/aws/aws-cdk/commit/a98a98147534f89a219521a2e51a6a1e25a2ac06)), closes [#​12999](https://togithub.com/aws/aws-cdk/issues/12999) - **stepfunctions-tasks:** Node.js 18.x runtime for `EvaluateExpression` ([#​25002](https://togithub.com/aws/aws-cdk/issues/25002)) ([f26bfe9](https://togithub.com/aws/aws-cdk/commit/f26bfe9c1465389f1c8f5ef80c4e6ed9279fc0c2)) ##### Bug Fixes - **cloudwatch:** `p100` statistic is no longer recognized ([#​24981](https://togithub.com/aws/aws-cdk/issues/24981)) ([adc1a13](https://togithub.com/aws/aws-cdk/commit/adc1a131c306eb3633a55b62cc301e276727a7da)), closes [#​23095](https://togithub.com/aws/aws-cdk/issues/23095) [#​24976](https://togithub.com/aws/aws-cdk/issues/24976) - **events-targets:** parameter JobName can exceed limit of 128 characters ([#​24786](https://togithub.com/aws/aws-cdk/issues/24786)) ([923b9f1](https://togithub.com/aws/aws-cdk/commit/923b9f19152eec889f10db9849ecf1db016c33f3)), closes [#​24654](https://togithub.com/aws/aws-cdk/issues/24654) - **redshift:** Column ids were not being default assigned ([#​24546](https://togithub.com/aws/aws-cdk/issues/24546)) ([8a655bd](https://togithub.com/aws/aws-cdk/commit/8a655bdb57fa178a7247a2c74bc24fd1ff6e67a1)), closes [#​24545](https://togithub.com/aws/aws-cdk/issues/24545) - **s3:** deprecate unencrypted encryption configuration for s3 bucket ([#​24770](https://togithub.com/aws/aws-cdk/issues/24770)) ([b971615](https://togithub.com/aws/aws-cdk/commit/b971615b6d5577c7c972e4a816d9f0de38fe56b5)) - ecr policy warning always throws ([#​25041](https://togithub.com/aws/aws-cdk/issues/25041)) ([c0c3d19](https://togithub.com/aws/aws-cdk/commit/c0c3d19039981eb71bb37b2b1e3a1d5c12025b4f)), closes [#​25028](https://togithub.com/aws/aws-cdk/issues/25028) - **core:** Add stage prefix to stack name shortening process ([#​24443](https://togithub.com/aws/aws-cdk/issues/24443)) ([55621ad](https://togithub.com/aws/aws-cdk/commit/55621adee7ee268c127333d0630eb93d1e472fa3)), closes [#​23628](https://togithub.com/aws/aws-cdk/issues/23628) - **servicecatalogappregistry:** Imported attribute group cannot be associated to an application ([#​24960](https://togithub.com/aws/aws-cdk/issues/24960)) ([4c2e7d6](https://togithub.com/aws/aws-cdk/commit/4c2e7d63b46490bbaf512b3c2b96efc189deb78d)) *** #### Alpha modules (2.74.0-alpha.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/cythral/brighid-discord-adapter). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40MC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDAuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Amazon.CDK.Lib](https://togithub.com/aws/aws-cdk) | nuget | minor | `2.73.0` -> `2.74.0` | --- ### Release Notes <details> <summary>aws/aws-cdk</summary> ### [`v2.74.0`](https://togithub.com/aws/aws-cdk/releases/tag/v2.74.0) ##### ⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES - **batch:** `ComputeEnvironment` has been removed and replaced by `ManagedEc2EcsComputeEnvironment`, `ManagedEc2EksComputeEnvironment`, and `UnmanagedComputeEnvironment`. `JobDefinition` has been removed and replaced by `EcsJobDefinition`, `EksJobDefinition`, and `MultiNodeJobDefinition` ##### Features - **batch:** new L2 Constructs ([#​24775](https://togithub.com/aws/aws-cdk/issues/24775)) ([92e6c67](https://togithub.com/aws/aws-cdk/commit/92e6c6706aae72d406cb5bf6a3f5c4d4885a5cb2)) - **ec2:** added ulimits property to ContainerDefinitionOptions ([#​24963](https://togithub.com/aws/aws-cdk/issues/24963)) ([e37d16a](https://togithub.com/aws/aws-cdk/commit/e37d16ada1572518b4859c9dbf68e9f08eb3f4eb)), closes [#​24918](https://togithub.com/aws/aws-cdk/issues/24918) - **pipelines:** allow artifactBucket to be overridden ([#​24945](https://togithub.com/aws/aws-cdk/issues/24945)) ([292c846](https://togithub.com/aws/aws-cdk/commit/292c846531cc3ecb033569953ebad1826d06c341)) - **sagemaker:** support dlc images in sagemaker model ([#​25018](https://togithub.com/aws/aws-cdk/issues/25018)) ([91553e5](https://togithub.com/aws/aws-cdk/commit/91553e5622fd702e5137f253d266e93b5f0b1a5e)), closes [/github.com/aws/aws-cdk/pull/17399/files#diff-356f35099770f68f4ceee2e63d34aad8729b0a9be6c933a0c05e999be7374685R98-R145](https://togithub.com/aws//github.com/aws/aws-cdk/pull/17399/files/issues/diff-356f35099770f68f4ceee2e63d34aad8729b0a9be6c933a0c05e999be7374685R98-R145) - **ses:** event destinations for configuration sets ([#​24745](https://togithub.com/aws/aws-cdk/issues/24745)) ([3be43eb](https://togithub.com/aws/aws-cdk/commit/3be43eb1f467a0defcca6a298fd7c5c41ab80b6e)) - **step-functions-tasks:** Support PropagatedTagSource property for EcsRunTask ([#​24949](https://togithub.com/aws/aws-cdk/issues/24949)) ([a98a981](https://togithub.com/aws/aws-cdk/commit/a98a98147534f89a219521a2e51a6a1e25a2ac06)), closes [#​12999](https://togithub.com/aws/aws-cdk/issues/12999) - **stepfunctions-tasks:** Node.js 18.x runtime for `EvaluateExpression` ([#​25002](https://togithub.com/aws/aws-cdk/issues/25002)) ([f26bfe9](https://togithub.com/aws/aws-cdk/commit/f26bfe9c1465389f1c8f5ef80c4e6ed9279fc0c2)) ##### Bug Fixes - **cloudwatch:** `p100` statistic is no longer recognized ([#​24981](https://togithub.com/aws/aws-cdk/issues/24981)) ([adc1a13](https://togithub.com/aws/aws-cdk/commit/adc1a131c306eb3633a55b62cc301e276727a7da)), closes [#​23095](https://togithub.com/aws/aws-cdk/issues/23095) [#​24976](https://togithub.com/aws/aws-cdk/issues/24976) - **events-targets:** parameter JobName can exceed limit of 128 characters ([#​24786](https://togithub.com/aws/aws-cdk/issues/24786)) ([923b9f1](https://togithub.com/aws/aws-cdk/commit/923b9f19152eec889f10db9849ecf1db016c33f3)), closes [#​24654](https://togithub.com/aws/aws-cdk/issues/24654) - **redshift:** Column ids were not being default assigned ([#​24546](https://togithub.com/aws/aws-cdk/issues/24546)) ([8a655bd](https://togithub.com/aws/aws-cdk/commit/8a655bdb57fa178a7247a2c74bc24fd1ff6e67a1)), closes [#​24545](https://togithub.com/aws/aws-cdk/issues/24545) - **s3:** deprecate unencrypted encryption configuration for s3 bucket ([#​24770](https://togithub.com/aws/aws-cdk/issues/24770)) ([b971615](https://togithub.com/aws/aws-cdk/commit/b971615b6d5577c7c972e4a816d9f0de38fe56b5)) - ecr policy warning always throws ([#​25041](https://togithub.com/aws/aws-cdk/issues/25041)) ([c0c3d19](https://togithub.com/aws/aws-cdk/commit/c0c3d19039981eb71bb37b2b1e3a1d5c12025b4f)), closes [#​25028](https://togithub.com/aws/aws-cdk/issues/25028) - **core:** Add stage prefix to stack name shortening process ([#​24443](https://togithub.com/aws/aws-cdk/issues/24443)) ([55621ad](https://togithub.com/aws/aws-cdk/commit/55621adee7ee268c127333d0630eb93d1e472fa3)), closes [#​23628](https://togithub.com/aws/aws-cdk/issues/23628) - **servicecatalogappregistry:** Imported attribute group cannot be associated to an application ([#​24960](https://togithub.com/aws/aws-cdk/issues/24960)) ([4c2e7d6](https://togithub.com/aws/aws-cdk/commit/4c2e7d63b46490bbaf512b3c2b96efc189deb78d)) *** #### Alpha modules (2.74.0-alpha.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/cythral/brighid-commands). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40MC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDAuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Based closely on PR #6107, this commit introduces the Endpoint L2 construct and the L2 constructs on which it depends, including Model and EndpointConfig. Departures from PR #6107 include:
DlcEcrImage
class for AWS Deep Learning ContainersAsyncInferenceConfig
Fixes #2809
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license