Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(iot-actions): simplify cloudwatch-logs-action test #17385

Merged
merged 4 commits into from
Nov 9, 2021
Merged

chore(iot-actions): simplify cloudwatch-logs-action test #17385

merged 4 commits into from
Nov 9, 2021

Conversation

yamatatsu
Copy link
Contributor

This PR refactor the test that I committed earlier based on the above comment.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 7, 2021

skinny85
skinny85 previously approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skinny85 skinny85 changed the title test(iot-actions): simplify cloudwatch-logs-action test chore(iot-actions): simplify cloudwatch-logs-action test Nov 8, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed skinny85’s stale review November 9, 2021 14:00

Pull request has been modified.

@yamatatsu yamatatsu requested a review from skinny85 November 9, 2021 15:09
@yamatatsu
Copy link
Contributor Author

yamatatsu commented Nov 9, 2021 •
edited
Loading

@skinny85
It seem that auto PR merging was blocked because CI failure on aa137d1 (#17385) 😵.
Could you approve once again? (I've no changed)

@skinny85
Copy link
Contributor

skinny85 commented Nov 9, 2021

@skinny85 It seem that auto PR merging was blocked because CI failure on aa137d1 (#17385) 😵. Could you approve once again? (I've no changed)

Done!

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 0bed861
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6937296 into aws:master Nov 9, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@yamatatsu yamatatsu deleted the aws-iot-actions-logs-test-refactoring branch November 10, 2021 12:06
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@yamatatsu @TikiTDO
chore(iot-actions): simplify cloudwatch-logs-action test (aws#17385)
59f365b 
This PR refactor the test that I committed earlier based on the above comment.

- aws#17307 (comment)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 skinny85 approved these changes

Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-iot-actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yamatatsu @skinny85 @aws-cdk-automation