fix(core): asset bundling fails for non-existent user #15313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
akuntsch
force-pushed
the
fix-local-bundling-with-non-existent-user
branch
from
7f58ce1 to
6f50ee9
Compare
|
Please don't forget to describe the bug you are fixing |
rix0rrr
previously requested changes
Jul 8, 2021
The user is only needed when bundling via Docker so there is no need to always call os.userInfo() as a default fallback even when bundling locally. Additionally, calling os.userInfo() can easily fail when already running inside a Docker container with non-existent uid and gid (e.g. when using the Jenkins Docker plugin).
akuntsch
force-pushed
the
fix-local-bundling-with-non-existent-user
branch
from
6f50ee9 to
1c66380
Compare
akuntsch
changed the title
|
@rix0rrr I've updated the PR title and description and the build was successful this time around. |
rix0rrr
changed the title
rix0rrr
changed the title
rix0rrr
approved these changes
Aug 10, 2021
rix0rrr
added
the
pr-linter/exempt-test
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
Currently, when not explicitly passing a user in BundlingOptions, `os.userInfo()` is called as a default fallback. Even though the user is only used and needed when using docker bundling, it is still called when using local bundling. This can be problematic e.g. when running cdk scripts inside a docker container where the user does not exist inside the container (see aws#15415). Fixes aws#15415. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24
pushed a commit
to david-doyle-as24/aws-cdk
that referenced
this pull request
Sep 7, 2021
Currently, when not explicitly passing a user in BundlingOptions, `os.userInfo()` is called as a default fallback. Even though the user is only used and needed when using docker bundling, it is still called when using local bundling. This can be problematic e.g. when running cdk scripts inside a docker container where the user does not exist inside the container (see aws#15415). Fixes aws#15415. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when not explicitly passing a user in BundlingOptions,
os.userInfo()is called as a default fallback. Even though the user is only used and needed when using docker bundling, it is still called when using local bundling. This can be problematic e.g. when running cdk scripts inside a docker container where the user does not exist inside the container (see #15415).Fixes #15415.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license