Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-kms): allow tagging kms keys #1485

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Conversation

rsmogura
Copy link
Contributor

@rsmogura rsmogura commented Jan 7, 2019

Small change to enable tagging KMS keys.


Pull Request Checklist

  • [X ] Testing
    • Unit test added
    • CLI change?: manually run integration tests and paste output as a PR comment
    • cdk-init template change?: coordinated update of integration tests with team
  • [X ] Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • [X ] Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Small change to enable tagging KMS keys.
@rsmogura rsmogura requested a review from a team as a code owner January 7, 2019 07:12
@eladb eladb merged commit f43b4d4 into aws:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants