Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(s3): autoDeleteObjects had redundant GetObject* permissions #14573

Merged
merged 10 commits into from
Jun 7, 2021
Merged

fix(s3): autoDeleteObjects had redundant GetObject* permissions #14573

merged 10 commits into from
Jun 7, 2021

Conversation

berenddeboer
Copy link
Contributor

This should fix #14572.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 6, 2021

@iliapolo iliapolo changed the title feat: allow only meta data to be retrieved, not any object itself fix(s3): autoDeleteObjects had redundant GetObject* permissions May 17, 2021
@github-actions github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label May 17, 2021
@iliapolo iliapolo changed the title fix(s3): autoDeleteObjects had redundant GetObject* permissions fix(s3): autoDeleteObjects had redundant GetObject* permissions May 17, 2021
iliapolo
iliapolo previously requested changes May 17, 2021
View reviewed changes
Copy link
Contributor

@iliapolo iliapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected to see a change in the corresponding expectation file. Did you run the integration test?

See https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md#integration-tests

packages/@aws-cdk/aws-s3/lib/bucket.ts Outdated Show resolved Hide resolved
@iliapolo iliapolo added effort/small Small work item – less than a day of effort p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels May 17, 2021
@github-actions
Copy link

This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label May 18, 2021
@mergify mergify bot dismissed iliapolo’s stale review May 23, 2021 22:34

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: ed2e1d0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f9be15d into aws:master Jun 7, 2021
@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@berenddeboer berenddeboer deleted the remove-get-object-permission-from-delete-lambda branch June 7, 2021 22:34
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@berenddeboer @hollanddd
fix(s3): autoDeleteObjects had redundant GetObject* permissions (a…
4db5fff 
…ws#14573)

This should fix  aws#14572.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliapolo iliapolo iliapolo approved these changes

Assignees

@iliapolo iliapolo

Labels
@aws-cdk/aws-s3 Related to Amazon S3 closing-soon This issue will automatically close in 4 days unless further comments are made. effort/small Small work item – less than a day of effort p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(s3): autoDeleteObjects policy attached to S3 bucket allows s3:GetObject permission
3 participants
@berenddeboer @aws-cdk-automation @iliapolo