Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): stack.exportValue() can be used to solve "deadly embrace" #12778

Merged
merged 7 commits into from
Feb 1, 2021
Merged

feat(core): stack.exportValue() can be used to solve "deadly embrace" #12778

merged 7 commits into from
Feb 1, 2021

Commits on Jan 29, 2021

  1. feat(core): manually control exports to solve "deadly embrace" 

    "Deadly embrace" is a great term but an annoying problem. The best
way to work around it is to manually ensure the CloudFormation Export
exists while you remove the consuming relationship. Adam has a blog
post about this, but the mechanism can be more smooth.

Add a method, `stack.exportAttribute(...)` which can be used to
create the Export for the duration of the deployment that breaks
the relationship, and add an explanation of how to use it.

Fixes #7602.
    @rix0rrr
    rix0rrr committed Jan 29, 2021
    Configuration menu
    Copy the full SHA
    56e3825 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2021

  1. Update packages/@aws-cdk/core/README.md 

    Co-authored-by: Elad Ben-Israel <[email protected]>
    @rix0rrr
    rix0rrr and Elad Ben-Israel authored Feb 1, 2021
    Configuration menu
    Copy the full SHA
    cd0fbe1 View commit details
    Browse the repository at this point in the history

  2. Update packages/@aws-cdk/core/README.md 

    Co-authored-by: Elad Ben-Israel <[email protected]>
    @rix0rrr
    rix0rrr and Elad Ben-Israel authored Feb 1, 2021
    Configuration menu
    Copy the full SHA
    c37632f View commit details
    Browse the repository at this point in the history

  3. Update packages/@aws-cdk/core/lib/stack.ts 

    Co-authored-by: Elad Ben-Israel <[email protected]>
    @rix0rrr
    rix0rrr and Elad Ben-Israel authored Feb 1, 2021
    Configuration menu
    Copy the full SHA
    d1091fa View commit details
    Browse the repository at this point in the history

  4. Touch up README, fix build

    @rix0rrr
    rix0rrr committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    7ff16d1 View commit details
    Browse the repository at this point in the history

  5. Extend API a bit

    @rix0rrr
    rix0rrr committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    ce715df View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into huijbers/deadly-embrace

    @mergify
    mergify[bot] authored Feb 1, 2021
    Configuration menu
    Copy the full SHA
    3cbcf66 View commit details
    Browse the repository at this point in the history