chore: apply mergify rules to v2-main branch #11939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same set of mergify rules are used for 'master' and 'v2-main' branches. With these changes, regular PRs from contributors get auto-merged. This is currently not the case. This also removes any special rules for v2 and reduces the number of rules.
|
|
eladb
reviewed
Dec 8, 2020
| @@ -121,22 +118,4 @@ pull_request_rules: | |||
| - "#approved-reviews-by>=1" | |||
| - "#changes-requested-reviews-by=0" | |||
| - status-success~=AWS CodeBuild us-east-1 | |||
| - status-success=validate-pr | |||
| - name: automatic merge of v2 forward merges | |||
There was a problem hiding this comment.
Don't we want auto-merge of FW merges?
There was a problem hiding this comment.
Of course. Once we get this in - https://github.com/aws/cdk-ops/pull/1009 - it should not be different from any other PR.
Auto approval is configured here - https://github.com/aws/aws-cdk/blob/master/.github/workflows/auto-approve-v2-merge-forward.yml
Something else I missed?
njlynch
approved these changes
Dec 8, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
flochaz
pushed a commit
to flochaz/aws-cdk
that referenced
this pull request
Jan 5, 2021
The same set of mergify rules are used for 'master' and 'v2-main' branches. With these changes, regular PRs from contributors get auto-merged. This is currently not the case. This also removes any special rules for v2 and reduces the number of rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same set of mergify rules are used for 'master' and 'v2-main'
branches.
With these changes, regular PRs from contributors get auto-merged. This
is currently not the case.
This also removes any special rules for v2 and reduces the number of
rules.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license