Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pkglint): don't allow adding peer dependencies to monocdk #10930

Merged
merged 9 commits into from
Oct 21, 2020
Merged

chore(pkglint): don't allow adding peer dependencies to monocdk #10930

merged 9 commits into from
Oct 21, 2020

Conversation

NetaNir
Copy link
Contributor

@NetaNir NetaNir commented Oct 17, 2020 •
edited
Loading

Adding a peer dependency to monocdk is a breaking change. Added a lint rule that only allows constructs as a peer dependency of monocdk.

This PR build is currently failing since cdk8s was added as a peer dependency of monocdk, thus breaking the rule. Once it is removed this PR will build successfully. See related discussion.

From the build logs:


monocdk: In package package.json
--
963 | monocdk: - [monocdk/no-peer] Adding a peer dependency to monocdk is a breaking change, and thus not allowed.
964 | monocdk:          Added cdk8s
965 | monocdk: Error: Some package.json files had errors

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 17, 2020
@NetaNir NetaNir requested a review from a team October 17, 2020 22:23
eladb
eladb reviewed Oct 18, 2020
View reviewed changes
tools/pkglint/lib/rules.ts Outdated Show resolved Hide resolved
@gitpod-io
Copy link

gitpod-io bot commented Oct 18, 2020 •
edited
Loading

@NetaNir NetaNir requested review from eladb and nija-at October 21, 2020 16:33
eladb
eladb approved these changes Oct 21, 2020
View reviewed changes
tools/pkglint/lib/rules.ts Outdated Show resolved Hide resolved
@eladb eladb added the pr/do-not-merge This PR should not be merged at this time. label Oct 21, 2020
@eladb
Copy link
Contributor

eladb commented Oct 21, 2020

added do-not-merge

NetaNir and others added 2 commits October 21, 2020 13:26
@NetaNir NetaNir removed the pr/do-not-merge This PR should not be merged at this time. label Oct 21, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a300280
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@NetaNir NetaNir merged commit 9c88a64 into master Oct 21, 2020
@NetaNir NetaNir deleted the neta/protect-mono branch October 21, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

@nija-at nija-at Awaiting requested review from nija-at

Assignees

@NetaNir NetaNir

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NetaNir @eladb @aws-cdk-automation @nija-at @iliapolo