Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): migrate constructs to use "constructs" module #10655

Merged
merged 6 commits into from
Oct 4, 2020
Merged

chore(core): migrate constructs to use "constructs" module #10655

merged 6 commits into from
Oct 4, 2020

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Oct 2, 2020 •
edited
Loading

With all of CDK construct libraries in the repo migrated1,2,3
to use "constructs" module, finally move "core" module also to
use the same pattern.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

chore(core): migrate constructs to use "constructs" module
9d176fa 
With the CDK construct library migrated[1][2][3] to use "constructs"
module, finally move "core" module also to use the same pattern.

[1]: c179699
[2]: 60c782f
[3]: a76428b
@nija-at nija-at self-assigned this Oct 2, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 2, 2020
@nija-at nija-at added the pr/do-not-merge This PR should not be merged at this time. label Oct 2, 2020
@nija-at nija-at requested review from eladb and a team October 2, 2020 13:55
@nija-at nija-at removed the pr/do-not-merge This PR should not be merged at this time. label Oct 4, 2020
@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 1db3f72
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 92080a2 into master Oct 4, 2020
@mergify mergify bot deleted the nija-at/core-constructcompat branch October 4, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@nija-at nija-at

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nija-at @aws-cdk-automation @eladb