[aws-codebuild] Add support for COMMIT_MESSAGE on FilterGroup

[jacques-]

Codebuild FilterGroup (https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-codebuild.FilterGroup.html) contains methods to filter on all attributes except COMMIT_MESSAGE.

Use Case

Would like to set a COMMIT_MESSAGE filter on builds - need to do this manually at the moment.

Proposed Solution

Propose adding an andCommitMessageIs method to FilterGroup.

Current workaround is to set this manually in console.

---

This is a 🚀 Feature Request

[skinny85]

Hey @jacques- ,

thanks for opening the issue. Any chance you can open us a PR with this? 😃 Should be a simple change in this class:

aws-cdk/packages/@aws-cdk/aws-codebuild/lib/source.ts

Line 192 in 4a714ee

export class FilterGroup {

. See our docs on how to get started with a contribution: https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md#getting-started

Let me know if this is something that might be interesting for you!

Thanks,
Adam

[jacques-]

Ok cool, I don't know typescript yet but I'll give it a go.

[jorge-barreto]

Hey, I just ran into a use case with the same need. I'm happy to look into creating a PR for this in the next day or so if it isn't being worked by anyone else.

One question I have (and excuse my ignorance here): my project works with the .NET implementation of CDK. What is the process for getting these changes in there?

[skinny85]

@jorge-barreto if you submit a change to the TypeScript code, it will be released for .NET - the logic is written only once and then distributed using JSII.

[jorge-barreto]

the logic is written only once and then distributed using JSII.

Thanks for giving me the skinny on that; cool tech!

[skinny85]

You're welcome @jorge-barreto , thanks for the great PR!

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.