Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add persistent stacks to integ test #5682

Closed
rix0rrr opened this issue Jan 7, 2020 · 1 comment
Closed

cli: add persistent stacks to integ test #5682

rix0rrr opened this issue Jan 7, 2020 · 1 comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. management/devenv Related to CDK development/build environment ops-excellence Operational Excellence p2 package/tools Related to AWS CDK Tools or CLI

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Jan 7, 2020

To discover issues like #5469, add a stack to the integration tests that is NOT cleaned up after every deployment.

Instead, we'll be exercising the CDK's ability to keep updating an existing stack with critical resources in there (to start, a Vpc but others may be added).

For most updates this should be a no-op so it shouldn't add more than 10s to a typical test run.
@rix0rrr rix0rrr added feature-request A feature should be added or improved. package/tools Related to AWS CDK Tools or CLI @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud needs-triage This issue or PR still needs to be triaged. ops-excellence Operational Excellence labels Jan 7, 2020
rix0rrr added a commit that referenced this issue Jan 7, 2020
@rix0rrr
chore(cli): test CDK can update an existing VPC
c953166 
Add an integration test with a stack that doesn't get cleaned up,
but updated on every test run.

This makes sure that new releases of the CDK can still update
stacks that have been deployed using previous CDK releases without
issue. We only test shared, long-lived resources which would be
a pain to drop and recreate if a CDK upgrade would break deploying
to them, like a VPC.

Fixes #5682.
@rix0rrr rix0rrr mentioned this issue Jan 7, 2020
Closed
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Jan 7, 2020
@rix0rrr rix0rrr added the effort/large Large work item – several weeks of effort label Jan 23, 2020
@rix0rrr rix0rrr added management/devenv Related to CDK development/build environment p2 labels Aug 12, 2020
@rix0rrr rix0rrr removed their assignment Jun 3, 2021
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 3, 2022
@github-actions github-actions bot closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. management/devenv Related to CDK development/build environment ops-excellence Operational Excellence p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(cli): test CDK can update an existing VPC aws/aws-cdk
2 participants
@rix0rrr @SomayaB