Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: toolkit fails to read config/credentials file #563

Closed
eladb opened this issue Aug 14, 2018 · 1 comment · Fixed by #565
Closed

Bug: toolkit fails to read config/credentials file #563

eladb opened this issue Aug 14, 2018 · 1 comment · Fixed by #565
Assignees
@eladb

Comments

@eladb
Copy link
Contributor

eladb commented Aug 14, 2018

Stack trace:

TypeError: ini.split is not a function
    at Object.string [as parse] (/Users/benisrae/code/cdk-bucket-notifications/aws-cdk/packages/aws-cdk/node_modules/aws-sdk/lib/util.js:197:26)
    at SharedIniFile.ensureFileLoaded (/Users/benisrae/code/cdk-bucket-notifications/aws-cdk/packages/aws-cdk/lib/api/util/sdk_ini_file.ts:49:51)
    at <anonymous>

The problem is that the call to fs.readFile in sdk_ini_file.ts returns a Buffer and not string as expected by ini.parse.
@eladb eladb self-assigned this Aug 14, 2018
@eladb
Copy link
Contributor Author

eladb commented Aug 14, 2018

On it

eladb pushed a commit that referenced this issue Aug 14, 2018
fix(toolkit): "ini.split is not a function" error when reading aws co…
f5d94fe 
…nfig

Since `readFile` returns a `Buffer` and `ini.parse` expects 
a string, we need `toString()`.

Fixes #563
@eladb eladb mentioned this issue Aug 14, 2018
Merged
eladb pushed a commit that referenced this issue Aug 14, 2018
fix(toolkit): "ini.split is not a function" error when reading aws co…
26d78ed 
…nfig (#565)

Since `readFile` returns a `Buffer` and `ini.parse` expects 
a string, we need `toString()`.

Fixes #563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Toolkit: fix "ini.split is not a function" error when reading config aws/aws-cdk
1 participant
@eladb