Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ecs): Support AL2023 #32496

Closed
1 of 2 tasks
phuhung273 opened this issue Dec 12, 2024 · 3 comments · Fixed by #32509
Closed
1 of 2 tasks

(ecs): Support AL2023 #32496

phuhung273 opened this issue Dec 12, 2024 · 3 comments · Fixed by #32509
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@phuhung273
Copy link
Contributor

Describe the feature

ECS support AL2023

Use Case

ECS support AL2023

Proposed Solution

ECS MachineImageType add AMAZON_LINUX_2023

Other Information

As instruction #32469 (comment)

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

latest

Environment details (OS name and version, etc.)

Amazon Linux 2023
@phuhung273 phuhung273 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 12, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Dec 12, 2024
@ashishdhingra ashishdhingra self-assigned this Dec 12, 2024
@ashishdhingra ashishdhingra added p2 investigating This issue is being investigated and/or work is in progress to resolve the issue. effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Dec 12, 2024
@ashishdhingra
Copy link
Contributor

@phuhung273 Good morning. I'm unsure if we need to track this separately from #32469 (comment). Perhaps, you could contribute PR as part of #32469 and close this issue. Please validate.

@ashishdhingra ashishdhingra removed the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Dec 12, 2024
@ashishdhingra ashishdhingra removed their assignment Dec 12, 2024
@ashishdhingra ashishdhingra added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Dec 12, 2024
@phuhung273
Copy link
Contributor Author

phuhung273 commented Dec 12, 2024 •
edited
Loading

Thanks @ashishdhingra. Can we leave this issue open ? For new AL2023 PR i will mention both issues.

Also another point, it must be:

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Dec 13, 2024
@phuhung273 phuhung273 mentioned this issue Dec 13, 2024
Merged
1 task
@mergify mergify bot closed this as completed in #32509 Dec 16, 2024
mergify bot pushed a commit that referenced this issue Dec 16, 2024
@phuhung273
feat(ecs): machineImageType support AL2023 (#32509)
4b696bc 
### Issue # (if applicable)

Closes #32496
Relate #32469 

### Reason for this change


- Invalid user data on AL2023

### Description of changes


- ECS `machineImageType` support AL2023

### Description of how you validated changes


Unit + Integration test

#### Instance can join cluster
![image](https://github.com/user-attachments/assets/aca9ffb3-b993-49f7-a432-eff0cd380952)
#### iptables command success
![image](https://github.com/user-attachments/assets/78edaee1-edc2-4ef8-9a9d-5e67e624c594)

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ecs): machineImageType support AL2023 phuhung273/aws-cdk
2 participants
@phuhung273 @ashishdhingra