feat(ec2-alpha): adding imports for SubnetV2 and VpcV2(WIP)

[shikha372]

Issue # (if applicable)

Tracking #30762.

Reason for this change

Allow users to define imports for a VPC or subnet defined outside current stack definition.

Description of changes

• Added new methods under VpcV2 and Subnet
  VpcV2.fromVpcV2Attributes() and SubnetV2.fromSubnetV2Attributes()

• Added new L2 for VPCCidrBlock to allow import of secondary addresses.
  VPCCidrBlock

• Added new integration test and unit test file to check import related functionality.

• Updated Readme.

• Fixed an earlier issue with subnet range check, fixed to include IPAM defined IPv4 address as well

Description of how you validated changes

Deployed and tested for below scenarios in account:

1. Import a VPC with primary IPv4
2. Import a subnet with primary IPv4
3. Import a VPC with multiple secondary IPv4
4. Import a VPC with Amazon provided IPV6
5. Import a VPC with Ipam provided IPv6/IPv4
6. Import subnet individually using fromSubnetV2attributes
7. Imported different type of multiple subnets
8. Add gateways/endpoint to imported vpc

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

BREAKING CHANGE: The new VpcCidrBlock L2 construct replaces CfnVPCCidrBlock. This change alters the logical ID of AWS::EC2::VPCCidrBlock resources in CloudFormation templates. Existing deployments will see errors like CIDR range conflicts with x.xx.xx.xx/xx with association ID vpc-cidr-assoc-ABCD. To resolve this, you must recreate your existing stacks to use the new module.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[moelasmar]

what is the value of providing the route table id? if it is needed, is it better to provide the route table object ?

[shikha372]

it will be used to add routes when attaching gateways, since routeTable interface only has the routeTableId as the property, i think just providing the Id should be enough to modify the class field using routetable id

this.routeTable = {
     routeTableId: props.routeTableId!,
   };

[moelasmar]

honestly, I do not have a strong opinion about it. The only thing I have in mind is passing an object will give us and customers other options to create the route table, and do more logic by invoking other functions.

In general in CDK, we prefer using strong typed Objects more than Ids.

[moelasmar]

do you know why these logical ids got changed although you did not change anything in the testing stack

[moelasmar]

we need to be careful about the logical ids changes, as it means that the old resources will be deleted, and create new resources, and this can be a breaking change for the customers.

[moelasmar]

I believe it is related to the change in packages/@aws-cdk/aws-ec2-alpha/lib/vpc-v2.ts when you replaced the CfnVPCCidrBlock resource with the new L2 resource. Could you please check if this is a breaking change (I mean if it will cause any outage for the customers or not during the update). If yes, I think it is ok since this module is an alpha module, but we need to highlight the change as a breaking change.

[moelasmar]

I verified that this is a breaking change. The stacks that got already deployed using the old construct will fail to be updated after this change and will get this error CIDR range conflicts with x.xx.xx.xx/xx with association ID vpc-cidr-assoc-ABCD .. we should highlight this issue as a breaking change.

[moelasmar]

Thanks Shikha, it looks good to me.

[moelasmar]

@Mergifyio update

[mergify]

update

✅ Branch has been successfully updated

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: f80fefa
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[moelasmar]

@Mergifyio merge

[mergify]

merge

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

[moelasmar]

@Mergifyio queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d108a80

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.