Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: support for proactive evaluation mode #30172

Closed
1 of 2 tasks
badmintoncryer opened this issue May 13, 2024 · 3 comments · Fixed by #30174 · 4 remaining pull requests
Closed
1 of 2 tasks

config: support for proactive evaluation mode #30172

badmintoncryer opened this issue May 13, 2024 · 3 comments · Fixed by #30174 · 4 remaining pull requests
Labels
@aws-cdk/aws-config Related to AWS Config effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@badmintoncryer
Copy link
Contributor

badmintoncryer commented May 13, 2024 •
edited
Loading

Describe the feature

CDK supports for proactive evaluation of AWS Config.

Use Case

AWS Config supports proactive evaluation in addition to detective mode.
https://docs.aws.amazon.com/config/latest/developerguide/evaluate-config-rules.html

However, CDK can only configure detective mode now.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.141.0

Environment details (OS name and version, etc.)

irrelevant
@badmintoncryer badmintoncryer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 13, 2024
@github-actions github-actions bot added the @aws-cdk/aws-config Related to AWS Config label May 13, 2024
@badmintoncryer badmintoncryer mentioned this issue May 13, 2024
Merged
1 task
@pahud
Copy link
Contributor

pahud commented May 13, 2024

@badmintoncryer We're looking forward to your PR as always. Thank you!

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels May 13, 2024
@github-actions github-actions bot mentioned this issue May 20, 2024
Closed
@github-actions github-actions bot mentioned this issue Jun 1, 2024
Closed
@mergify mergify bot closed this as completed in #30174 Jun 6, 2024
mergify bot pushed a commit that referenced this issue Jun 6, 2024
@badmintoncryer
feat(config): proactive evaluation mode (#30174)
516ecef 
### Issue # (if applicable)

Closes #30172.

### Reason for this change

AWS Config supports for proactive evaluation mode but L2 construct cannot configure it. 

### Description of changes

- Define `EvaluationMode` class
- Add `evaluationModes` prop to `RuleProps` 

```ts
new config.ManagedRule(stack, 'ManagedRule', {
  identifier: config.ManagedRuleIdentifiers.API_GW_XRAY_ENABLED,
  evaluationModes: config.EvaluationMode.DETECTIVE_AND_PROACTIVE, // add
});
```

### Description of how you validated changes

Add both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Leo10Gama pushed a commit to Leo10Gama/aws-cdk that referenced this issue Jun 11, 2024
@badmintoncryer
feat(config): proactive evaluation mode (aws#30174)
1ee9a97 
### Issue # (if applicable)

Closes aws#30172.

### Reason for this change

AWS Config supports for proactive evaluation mode but L2 construct cannot configure it. 

### Description of changes

- Define `EvaluationMode` class
- Add `evaluationModes` prop to `RuleProps` 

```ts
new config.ManagedRule(stack, 'ManagedRule', {
  identifier: config.ManagedRuleIdentifiers.API_GW_XRAY_ENABLED,
  evaluationModes: config.EvaluationMode.DETECTIVE_AND_PROACTIVE, // add
});
```

### Description of how you validated changes

Add both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mazyu36 pushed a commit to mazyu36/aws-cdk that referenced this issue Jun 22, 2024
@badmintoncryer @mazyu36
feat(config): proactive evaluation mode (aws#30174)
5d15c6d 
### Issue # (if applicable)

Closes aws#30172.

### Reason for this change

AWS Config supports for proactive evaluation mode but L2 construct cannot configure it. 

### Description of changes

- Define `EvaluationMode` class
- Add `evaluationModes` prop to `RuleProps` 

```ts
new config.ManagedRule(stack, 'ManagedRule', {
  identifier: config.ManagedRuleIdentifiers.API_GW_XRAY_ENABLED,
  evaluationModes: config.EvaluationMode.DETECTIVE_AND_PROACTIVE, // add
});
```

### Description of how you validated changes

Add both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@kazimanzurrashid kazimanzurrashid mentioned this issue Jun 29, 2024
Open
This was referenced Jun 29, 2024
Open
Open
This was referenced Jul 12, 2024
Open
Open
This was referenced Jul 19, 2024
Open
Open
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-config Related to AWS Config effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
3 participants
@pahud @aws-cdk-automation @badmintoncryer