Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn/fail synthesis when reached the 200 resource limit #276

Closed
eladb opened this issue Jul 10, 2018 · 6 comments · Fixed by #12193
Closed

Warn/fail synthesis when reached the 200 resource limit #276

eladb opened this issue Jul 10, 2018 · 6 comments · Fixed by #12193
Assignees
@rix0rrr
Labels
@aws-cdk/core Related to core CDK functionality effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@eladb
Copy link
Contributor

eladb commented Jul 10, 2018

Stack synthesis should fail if number of resources exceeds 200 (potentially warn if we are at 80% of that).
@rix0rrr
Copy link
Contributor

rix0rrr commented Jul 10, 2018

If we tackle #233 and automatically form stacks, we can split >200 resources over multiple stacks automatically.

@rix0rrr rix0rrr added feature-request A feature should be added or improved. and removed feature-request A feature should be added or improved. feature labels Nov 6, 2018
@eladb eladb self-assigned this Aug 27, 2019
@eladb
Copy link
Contributor Author

eladb commented Oct 2, 2019

still relevant

@eladb eladb added contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md labels Jan 23, 2020
@davidrupp davidrupp mentioned this issue Apr 16, 2020
Closed
@davidrupp
Copy link

I'm painfully aware that this PR doesn't include unit tests; couldn't figure out a way to add one usefully, hoping a seasoned core dev can give me some pointers. I did verify manually by building and linking the change locally against a sample app with varying numbers of resources (< 160, 160 - 200, > 200).

@SomayaB SomayaB added in-progress This issue is being actively worked on. @aws-cdk/core Related to core CDK functionality and removed contribution/core This is a PR that came from AWS. labels Apr 16, 2020
@eladb eladb removed the in-progress This issue is being actively worked on. label Jun 24, 2020
@eladb eladb added the p2 label Aug 17, 2020
@eladb eladb assigned rix0rrr and unassigned eladb Aug 17, 2020
@rzamana rzamana mentioned this issue Dec 22, 2020
Merged
@rzamana
Copy link
Contributor

rzamana commented Dec 22, 2020

@davidrupp Created my PR based on your work!! Thanks! How can I give you the proper mentioning?

@davidrupp
Copy link

No need. I'm glad it ended up being useful. :-)

@mergify mergify bot closed this as completed in #12193 Jan 11, 2021
mergify bot pushed a commit that referenced this issue Jan 11, 2021
@rzamana
feat(core): validate maximum amount of resources in a stack (#12193)
26121c8 
closes #276
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/core Related to core CDK functionality effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
5 participants
@davidrupp @rzamana @rix0rrr @eladb @SomayaB