aws-cdk-lib/aws-ec2: "Malformed instance type identifier" when creating ec2 instance of type 'm7i-flex.large'

[matt-mclaughlin-quantum-si]

Describe the bug

I'm trying to add an m7i-flex.large instance to a managed node group per
createManagedComputeNodes( name, subnet, [ new ec2.InstanceType('m7i-flex.large'), ], eks.CapacityType.SPOT, );

But receive a Malformed instance type identifier when doing so.

Expected Behavior

I'm able to add the m7i-flex.large instance type as an instance choice for the managed node group

Current Behavior

Error: Malformed instance type identifier
    at InstanceType.sameInstanceClassAs (/node_modules/aws-cdk-lib/aws-ec2/lib/instance-types.js:1:17751)
    at /node_modules/aws-cdk-lib/aws-eks/lib/managed-nodegroup.js:1:7443
    at Array.some (<anonymous>)
    at isGpuInstanceType (/node_modules/aws-cdk-lib/aws-eks/lib/managed-nodegroup.js:1:7422)
    at typeToArch (/node_modules/aws-cdk-lib/aws-eks/lib/managed-nodegroup.js:1:8182)
    at Array.map (<anonymous>)
    at getPossibleAmiTypes (/node_modules/aws-cdk-lib/aws-eks/lib/managed-nodegroup.js:1:8442)
    at new Nodegroup (/node_modules/aws-cdk-lib/aws-eks/lib/managed-nodegroup.js:1:3543)
    at Cluster.addNodegroupCapacity (/node_modules/aws-cdk-lib/aws-eks/lib/cluster.js:1:19557)

Node.js v20.5.0

Reproduction Steps

Add a m7i-flex.large instance type to a managed node group per "Describe the bug". Then run cdk synthesize.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.101.1 (build 16ddad1)

Framework Version

No response

Node.js Version

20.5.0

OS

MAC OS Monterey 12.6.1

Language

TypeScript

Language Version

No response

Other information

No response

[peterwoodworth]

The regex doesn't allow for hyphens, ths would need to change

aws-cdk/packages/aws-cdk-lib/aws-ec2/lib/instance-types.ts

Line 1393 in b2a895e

const instanceClass: RegExp = /^([a-z]+\d{1,2}[a-z]*)\.([a-z0-9]+)$/;

[bibhu107]

I would like to contribute here!
Thanks

[scanlonp]

@matt-mclaughlin-quantum-si would defining it by ec2.InstanceType.of(ec2.InstanceClass.M7I_FLEX, ec2.InstanceSize.LARGE) work? That looks like the preferred instantiation.

[matt-mclaughlin-quantum-si]

@matt-mclaughlin-quantum-si would defining it by ec2.InstanceType.of(ec2.InstanceClass.M7I_FLEX, ec2.InstanceSize.LARGE) work? That looks like the preferred instantiation.

@scanlonp Went ahead and tested with that method, but it produces the same result

[jsamuel1]

This also affects calling the architecture property of instance type, when constructed with the string 'm7i-flex'.

// repo aws-cdk-lib 2.115.0, typescript:
var instanceType = new ec2.InstanceType('m7i-flex.xlarge');
var cpuArch : string = instanceType.architecture;
console.log(`cpuArch: ${cpuArch}`);

Compiler Output:

Error: Malformed instance type identifier
    at InstanceType.get architecture [as architecture] (XXXX/node_modules/aws-cdk-lib/aws-ec2/lib/instance-types.js:1:18931)

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.