Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-ses): expose scalingMode property on DedicatedIPPool #27418

Closed
1 of 2 tasks
tobiasviehweger opened this issue Oct 5, 2023 · 2 comments · Fixed by #28392
Closed
1 of 2 tasks

(aws-ses): expose scalingMode property on DedicatedIPPool #27418

tobiasviehweger opened this issue Oct 5, 2023 · 2 comments · Fixed by #28392
Labels
@aws-cdk/aws-ses Related to Amazon Simple Email Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@tobiasviehweger
Copy link

Describe the feature

Currently, you can only create dedicated IP pools with scaling mode "standard" as the scalingMode property from CfnDedicatedIpPool is not exposed in DedicatedIpPool.

Use Case

I want to create a managed IP pool :)

Proposed Solution

Expose property "scalingMode" with typed enum.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.99.1

Environment details (OS name and version, etc.)

Windows 11
@tobiasviehweger tobiasviehweger added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 5, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ses Related to Amazon Simple Email Service label Oct 5, 2023
@khushail
Copy link
Contributor

khushail commented Oct 5, 2023 •
edited
Loading

Thanks @tobiasviehweger for submitting this feature request. Your contributions are welcome.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Oct 5, 2023
@github-actions github-actions bot mentioned this issue Nov 1, 2023
Closed
@badmintoncryer badmintoncryer mentioned this issue Dec 16, 2023
Merged
@mergify mergify bot closed this as completed in #28392 Dec 19, 2023
mergify bot pushed a commit that referenced this issue Dec 19, 2023
@badmintoncryer
feat(ses): add scalingMode property to dedicated ip pool (#28392)
c687778 
Closes #27418

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ses Related to Amazon Simple Email Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ses): add scalingMode property to dedicated ip pool badmintoncryer/aws-cdk
2 participants
@tobiasviehweger @khushail