Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ec2): add metadata for M7gd, R7gd, C7gd instance types #26774

Closed
1 of 2 tasks
funguy-tech opened this issue Aug 16, 2023 · 2 comments · Fixed by #26776
Closed
1 of 2 tasks

(ec2): add metadata for M7gd, R7gd, C7gd instance types #26774

funguy-tech opened this issue Aug 16, 2023 · 2 comments · Fixed by #26776
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud aws-cdk-lib Related to the aws-cdk-lib package effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@funguy-tech
Copy link
Contributor

funguy-tech commented Aug 16, 2023 •
edited
Loading

Describe the feature

As of v2.92.0, we don't yet have C7gd, M7gd, and R7gd instance types available via instance type selection.

Use Case

These instance types were announced in July 2023 and are now live for select regions, as seen in this release.

Proposed Solution

Add new instance types to InstanceType enum and internal instanceClassMap, following the paradigm set by the *6gd subfamily of instance types.

Other Information

Proposed solution is #26776

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.92.0

Environment details (OS name and version, etc.)

Platform Independent
@funguy-tech funguy-tech added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 16, 2023
@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label Aug 16, 2023
@funguy-tech funguy-tech changed the title (module name): (short issue description) (ec2): add metadata for M7gd, R7gd, C7gd instance types Aug 16, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Aug 16, 2023
@funguy-tech funguy-tech mentioned this issue Aug 16, 2023
Merged
@pahud
Copy link
Contributor

pahud commented Aug 16, 2023

Awesome! Thank you for the PR!

@pahud pahud added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 16, 2023
@mergify mergify bot closed this as completed in #26776 Aug 18, 2023
mergify bot pushed a commit that referenced this issue Aug 18, 2023
@funguy-tech
chore(ec2): add M7gd, R7gd, C7gd instance types (#26776)
728af19 
As of v2.92.0, we don't yet have C7gd, M7gd, and R7gd instance types available via instance type selection. 

Closes #26774

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud aws-cdk-lib Related to the aws-cdk-lib package effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ec2): add M7gd, R7gd, C7gd instance types funguy-tech/aws-cdk
2 participants
@pahud @funguy-tech