Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-cdk: unmaintained transitive dependency with critical vulnerabilities #26417

Closed
orien opened this issue Jul 19, 2023 · 4 comments · Fixed by #26438
Closed

aws-cdk: unmaintained transitive dependency with critical vulnerabilities #26417

orien opened this issue Jul 19, 2023 · 4 comments · Fixed by #26438
Labels
bug This issue is a bug. dependencies This issue is a problem in a dependency or a pull request that updates a dependency file. p1 package/tools Related to AWS CDK Tools or CLI SECURITY

Comments

@orien
Copy link

orien commented Jul 19, 2023

Describe the bug

The AWS CDK has a transitive dependency on the vm2 library.

aws-cdkproxy-agentpac-proxy-agentpac-resolverdegeneratorvm2

This library is no-longer maintained, as noted on the GitHub repository:

The library contains critical security issues and should not be used for production! The maintenance of the project has been discontinued.

https://github.com/patriksimek/vm2#%EF%B8%8F-project-discontinued-%EF%B8%8F

It also has unpatched critical security issues, for example: CVE-2023-37466

Expected Behavior

yarn audit reports no critical vulnerabilities.

Current Behavior

yarn audit reports 4 critical vulnerabilities, all on the vm2 library.

Reproduction Steps

yarn install
yarn audit

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.87.0

Framework Version

No response

Node.js Version

18

OS

Linux

Language

Typescript

Language Version

No response

Other information

No response

@orien orien added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 19, 2023
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Jul 19, 2023
@orien
Copy link
Author

orien commented Jul 19, 2023

A fix has been released in proxy-agent v6.3.0.

Upgrading proxy-agent to ^6.3.0 should resolve this issue.

"proxy-agent": "^5.0.0",

@indrora indrora added SECURITY dependencies This issue is a problem in a dependency or a pull request that updates a dependency file. p0 p1 and removed needs-triage This issue or PR still needs to be triaged. p0 labels Jul 19, 2023
@indrora
Copy link
Contributor

indrora commented Jul 19, 2023

Thanks for telling us about this. I'm surprised Dependabot didn't tell us about it.

tagging @aws/aws-cdk-owners for viz : Dependabot didn't catch this it looks like.

@mrgrain
Copy link
Contributor

mrgrain commented Jul 19, 2023

Thanks for the report! I'll get this in for the next release.

@mergify mergify bot closed this as completed in #26438 Jul 20, 2023
mergify bot pushed a commit that referenced this issue Jul 20, 2023
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.

Closes #26417
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. dependencies This issue is a problem in a dependency or a pull request that updates a dependency file. p1 package/tools Related to AWS CDK Tools or CLI SECURITY
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants