Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeBuild: Missing the latest aws/codebuild/standard:2.0 Docker image #2606

Closed
thesurlydev opened this issue May 21, 2019 · 5 comments
Closed
Labels
bug This issue is a bug.

Comments

@thesurlydev
Copy link
Contributor

Describe the bug
The LinuxBuildImage class is missing UBUNTU_18_04_STANDARD_2_0

Expected behavior
CDK should include all the standard Docker images provided by CodeBuild as listed here: https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-available.html

Version:

  • Ubuntu 18.04
  • Kotlin with Java CDK artfifacts
  • 0.31.0
@thesurlydev thesurlydev added the bug This issue is a bug. label May 21, 2019
@skinny85
Copy link
Contributor

Hey @digitalsanctum ,

the standard image instances have been renamed to LinuxBuildImage.STANDARD_1_0 and STANDARD_2_0in #2541 . The reason is that they're no longer tied to the Ubuntu 18.04 platform (the platform might change with time, for example to the next Ubuntu LTS release), hence the name change.

Hope this clears this up, let me know if not.

@thesurlydev
Copy link
Contributor Author

@skinny85 Thanks for clarification. I just need to wait for the next release then. In the meantime, I'm using the following: LinuxBuildImage.fromDockerHub("aws/codebuild/standard:2.0")

@knorms101
Copy link
Contributor

@skinny85 Users cannot choose the latest CodeBuild images until a new static constant is added to LinuxBuildImages and the user updates to the latest version of cdk. Users may want the latest images, but be unable to update due to some breaking cdk change.

The work-around that @digitalsanctum proposed for using the latest aws CodeBuild image, .fromDockerHub is no longer available. Would it be possible to expose a different work-around? I notice in aws-codebuild/lib/project.ts all the static CodeBuild images are created using a private codebuildImage method. Could this method be exposed so users could specify the latest image?

@skinny85
Copy link
Contributor

@knorms101 that is an excellent point. Would you be willing to whip up a quick PR fixing this problem, and adding the appropriate documentation to the CodeBuild's project ReadMe?

@knorms101
Copy link
Contributor

@skinny85 Absolutely! Thanks.

mergify bot pushed a commit that referenced this issue Apr 2, 2020
feat: add from codebuild image option

Addresses comment [here](#2606 (comment)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

3 participants