Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(provider-framework): (lambda runtime still using NODEJS_14) #25940

Closed
alexherriott opened this issue Jun 12, 2023 · 2 comments · Fixed by #25995
Closed

(provider-framework): (lambda runtime still using NODEJS_14) #25940

alexherriott opened this issue Jun 12, 2023 · 2 comments · Fixed by #25995
Labels
@aws-cdk/aws-lambda Related to AWS Lambda bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@alexherriott
Copy link

Describe the bug

as part of release 2.77.0 lambdas were updated from nodejs14 to nodejs 16.
https://github.com/aws/aws-cdk/releases/tag/v2.77.0

however it seems that some were missed - https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/custom-resources/lib/provider-framework/provider.ts
nodejs_14 is still being used

Expected Behavior

nodejs_16 to be used for all CDK generated lambdas since release 2.77.0

Current Behavior

NODEJS_14 is still used in some cases

Reproduction Steps

deploy CDK which uses custom provider.

Possible Solution

update all lambdas so they do not use NODEJS_14

Additional Information/Context

No response

CDK CLI Version

2.77.0

Framework Version

No response

Node.js Version

16.20.0

OS

Ubuntu standard:6.0

Language

Typescript

Language Version

Typescript 4.9.4

Other information

No response
@alexherriott alexherriott added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jun 12, 2023
@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Jun 12, 2023
@peterwoodworth peterwoodworth added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jun 12, 2023
@peterwoodworth
Copy link
Contributor

Thanks for the report 👍🏻

@MrArnoldPalmer MrArnoldPalmer mentioned this issue Jun 15, 2023
Merged
@mergify mergify bot closed this as completed in #25995 Jun 20, 2023
mergify bot pushed a commit that referenced this issue Jun 20, 2023
@MrArnoldPalmer
fix: remaining usage of node 14 (#25995)
67975ed 
Remove some leftover usage of NODE_14_X in custom resources vended in
aws-cdk-lib. Changed to using the default runtime for the region.


Closes #25940

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

This was referenced Jul 26, 2023
Closed
Closed
@awsdataarchitect awsdataarchitect mentioned this issue Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-lambda Related to AWS Lambda bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remaining usage of node 14 aws/aws-cdk
2 participants
@alexherriott @peterwoodworth